New issue
Advanced search Search tips

Issue 651265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony [Mac] - make Default button pressed state darker

Project Member Reported by shrike@chromium.org, Sep 29 2016

Issue description

bettes@ has changed the pressed state overlay from alpha = 0.08 to alpha = 0.12. This is documented in the spec.

 

Comment 1 by shrike@chromium.org, Sep 29 2016

Labels: -OS-Linux -OS-Windows -OS-Chrome
Looks like it really is Mac-only.
Labels: Proj-HarmonyControls
Correction: the pressed state overlay has increased from 0.05a to 0.1a.
Status: Started (was: Assigned)
Before and after attached for https://codereview.chromium.org/2393493005
0.1a.png
54.8 KB View Download
0.05a.png
54.7 KB View Download
Hard to see a difference but you should land it and let's play with in Canary.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f225b41e65703041ea663cf5d6f85ca8c7c0d406

commit f225b41e65703041ea663cf5d6f85ca8c7c0d406
Author: ellyjones <ellyjones@chromium.org>
Date: Wed Oct 05 17:42:12 2016

views: Mac pressed button shade 0.05a -> 0.1a

BUG= 651265 

Review-Url: https://codereview.chromium.org/2393493005
Cr-Commit-Position: refs/heads/master@{#423209}

[modify] https://crrev.com/f225b41e65703041ea663cf5d6f85ca8c7c0d406/ui/native_theme/native_theme_mac.mm

Status: Fixed (was: Started)
This is now Fixed.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f225b41e65703041ea663cf5d6f85ca8c7c0d406

commit f225b41e65703041ea663cf5d6f85ca8c7c0d406
Author: ellyjones <ellyjones@chromium.org>
Date: Wed Oct 05 17:42:12 2016

views: Mac pressed button shade 0.05a -> 0.1a

BUG= 651265 

Review-Url: https://codereview.chromium.org/2393493005
Cr-Commit-Position: refs/heads/master@{#423209}

[modify] https://crrev.com/f225b41e65703041ea663cf5d6f85ca8c7c0d406/ui/native_theme/native_theme_mac.mm

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment