New issue
Advanced search Search tips

Issue 651261 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome , Mac
Pri: 1
Type: Feature

Blocked on:
issue 660309

Blocking:
issue 436283



Sign in to add a comment

bluetooth: Ship Web Bluetooth out of Origin Trial

Project Member Reported by scheib@chromium.org, Sep 29 2016

Issue description

Enable Web Bluetooth by default by taking it out of Origin Trial for all platforms. The feature should be enabled by default on ChromeOS, Android, and macOS. Windows and Linux require a command line flag.

Remove the --enable-we-bluetooth command line flag, and instead use --enable-experimental-web-platform-features to enable the feature on non-shipped platforms. https://www.chromium.org/blink/runtime-enabled-features
 
 
Description: Show this description

Comment 2 by juncai@chromium.org, Oct 11 2016

Owner: juncai@chromium.org
Status: Started (was: Available)

Comment 3 by scheib@chromium.org, Oct 19 2016

Description: Show this description

Comment 4 by scheib@chromium.org, Oct 19 2016

Summary: bluetooth: Ship Web Bluetooth out of Origin Trial (was: bluetooth: Field trial to ship Web Bluetooth)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ad09e105c07e4b22423866f4d16ed5adfe6db45

commit 3ad09e105c07e4b22423866f4d16ed5adfe6db45
Author: juncai <juncai@chromium.org>
Date: Fri Oct 28 03:08:06 2016

Ship WebBluetooth out of origin trial

Intent to Ship: Web Bluetooth
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Ono3RWkejAA/discussion

This CL does the following to move WebBluetooth out of origin trial:
1. Remove the --enable-web-bluetooth flag.
2. Use --enable-experimental-web-platform-features flag to enable
WebBluetooth on non-shipped platforms.
3. Remove the origin trial for WebBluetooth.
4. Two files are added:
third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt

Because currently Web Bluetooth is not supported on Linux
or Windows, and in those platforms the Web Bluetooth
bindings are not exposed. So in order to pass the
Layout tests on Linux and Windows, the new added expected
file: "global-interface-listing-expected.txt" doesn't
contain Web Bluetooth interfaces.

TEST=Manual testing required:

In each scenario below, to "Execute Test":
  For each URL
    https://googlechrome.github.io/samples/web-bluetooth/device-information-characteristics.html
    https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html

  Perform the following:
    Open Chrome Developer Tools Console
    Execute: "navigator.bluetooth && navigator.bluetooth.requestDevice({filters: [{services: ['human_interface_device']}]})"

  "WebBluetooth works" when this response is returned:
    "Uncaught (in promise) DOMException: requestDevice() called with a filter containing a blacklisted UUID."
  (the request for a blacklisted UUID is correctly rejected by the browser).

1. Run chrome without any flag:

ChromeOS, Android, MacOS:
  Execute Test and expect: WebBluetooth works.

Linux, Windows:
  Execute Test and expect: "undefined", bindings are not exposed.

2. Run Chrome with flag: --enable-experimental-web-platform-features

ChromeOS, Android, MacOS, Linux, Windows:
  Execute Test and expect: WebBluetooth works.

BUG= 651261 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2437943002
Cr-Commit-Position: refs/heads/master@{#428265}

[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/chrome/app/generated_resources.grd
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/chrome/browser/about_flags.cc
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/chrome/browser/web_bluetooth_browsertest.cc
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/content/child/runtime_features.cc
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/content/public/common/content_switches.cc
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/content/public/common/content_switches.h
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/content/shell/app/shell_main_delegate.cc
[add] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/OWNERS
[add] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/OWNERS
[add] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/Bluetooth.h
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/3ad09e105c07e4b22423866f4d16ed5adfe6db45/third_party/WebKit/Source/web/ChromeClientImpl.cpp

Blockedon: 660309
Status: Fixed (was: Started)
verified on chrome-OS. It works fine
Status: Verified (was: Fixed)

Sign in to add a comment