New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651255 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Remove media-router flag

Project Member Reported by sko...@chromium.org, Sep 28 2016

Issue description

Now that Media Router has gone to stable and is working well, we should remove the Chrome flag that allows users to explicitly disable it.  Currently this allows users to still use the old, legacy extension -- but it's rotting and will not be working much longer, so we need a way to force users onto the new functionality upon upgrade.
 
Do we have stats on how many users have used the flag to force the old behavior?  I'm assuming it's a very small number, but perhaps worth checking.

Comment 2 by sko...@chromium.org, Sep 29 2016

Mark and I checked Analytics, and there are a very small number of users on
52 & 53 who are using the old extension, so I'm not too worried there.  And
according to "life of a Chrome feature," once our thing is baked we're
supposed to remove the flag.

Comment 3 by woxxom@gmail.com, Sep 29 2016

If you remove the flag, how would it be possible to remove the "Cast..." item from page context menu? This functionality isn't used by the majority of users so it shouldn't clutter the menu in order not to undermine simplicity of Chrome/Chromium.
I fully agree it's the right thing to do per normal Chrome process, and was only looking to understand the worst-case possible impact for users who had a specific need for something in the old extension.  #2 data suggests no concern here.

Comment 5 by mfo...@chromium.org, Oct 25 2016

Cc: sko...@chromium.org imch...@chromium.org
Owner: mfo...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac0030f5d07e66752b93695bc373bcb55ab26602

commit ac0030f5d07e66752b93695bc373bcb55ab26602
Author: mfoltz <mfoltz@chromium.org>
Date: Fri Oct 28 21:16:52 2016

[Media Router] Update Media Router flags post-launch.

- Remove --media-router flag as this functionality has shipped
  ( crbug.com/651255 )

- Remove lots of GOOGLE_CHROME_BUILD #ifdefs around cloud services
  ( crbug.com/646171 )

- Adds a --load-media-router-component-extension flag to control loading of the
  Media Router component.  This is default on in Chrome and default off in
  Chromium.  ( crbug.com/646170 )

BUG= 646170 , 646171 , 651255 

Review-Url: https://codereview.chromium.org/2451573003
Cr-Commit-Position: refs/heads/master@{#428493}

[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/app/generated_resources.grd
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/about_flags.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/extensions/extension_context_menu_model_unittest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/extensions/external_component_loader.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/media/router/media_router_feature.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/profiles/profile.cc
[delete] https://crrev.com/f70deac4299d792a31b03bfe1dadc335e3a01a22/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/location_bar/location_bar_browsertest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/toolbar/media_router_contextual_menu.h
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/views/location_bar/page_action_image_view_interactive_uitest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/webui/media_router/media_router_localized_strings_provider.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/webui/media_router/media_router_test.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/webui/media_router/media_router_test.h
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/common/chrome_switches.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/common/chrome_switches.h
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/common/pref_names.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/common/pref_names.h
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/test/BUILD.gn
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/test/media_router/media_router_base_browsertest.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/chrome/test/media_router/media_router_base_browsertest.h
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/extensions/common/feature_switch.cc
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/extensions/common/feature_switch.h
[modify] https://crrev.com/ac0030f5d07e66752b93695bc373bcb55ab26602/tools/metrics/histograms/histograms.xml

Comment 7 by mfo...@chromium.org, Oct 28 2016

Status: Fixed (was: Started)

Sign in to add a comment