ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest tests are flaky |
||||||||||||
Issue description
I just ran a debug Linux build locally of components_unittests.
I noticed failures of this test that were automatically retried and it passed:
[ RUN ] ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest.CreateConnectionRequestTest
../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc:73: Failure
Value of: packet
Actual: { '\x1' (1) }
Expected: expected
Which is: { '\x80' (128), '\0', '\x1' (1), '\0', '\x1' (1), '\0', '\0' }
[ FAILED ] ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest.CreateConnectionRequestTest (0 ms)
[6869/7828] ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest.CreateConnectionRequestTest (0 ms)
[ RUN ] ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest.CreateConnectionResponseWithDefaultPacketSizeTest
[105477:105477:0928/161258:7192586609384:ERROR:bluetooth_low_energy_weave_client_connection_unittest.cc(166)] Not implemented reached in virtual Packet proximity_auth::weave::(anonymous namespace)::MockBluetoothLowEnergyWeavePacketGenerator::CreateConnectionResponse()
../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc:93: Failure
Value of: packet
Actual: {}
Expected: expected_default
Which is: { '\x81' (129), '\0', '\x1' (1), '\0', '\x14' (20) }
[ FAILED ] ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest.CreateConnectionResponseWithDefaultPacketSizeTest (0 ms)
The flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=components_unittests&tests=ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest.CreateConnectionRequestTest
Shows that this is flaky across many machines.
This test should be fixed.
,
Sep 28 2016
Also +reviewers of original change
,
Oct 5 2016
,
Oct 5 2016
I'm going to mark all of these tests flaky, it's clear there is something very wrong with this component.
,
Oct 5 2016
+rkc Another reason to remove code that seems not in use.
,
Oct 5 2016
,
Oct 5 2016
The receiver tests are also failing for me with things like: [ RUN ] ProximityAuthBluetoothLowEnergyWeavePacketReceiverTest.WellBehavingServerPacketsWithSomeControlDataTest ../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc:188: Failure Value of: receiver->GetState() Actual: 5 Expected: State::DATA_READY Which is: 3 ../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc:189: Failure Value of: receiver->GetDataMessage() Actual: "bb" Expected: "a" ../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc:201: Failure Value of: receiver->GetState() Actual: 5 Expected: State::RECEIVING_DATA Which is: 2 ../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc:212: Failure Value of: receiver->GetState() Actual: 5 Expected: State::DATA_READY Which is: 3 ../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc:213: Failure Value of: receiver->GetDataMessage() Actual: "bb" Expected: "ooooooooooooooooooopq" ../../components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc:222: Failure Value of: receiver->GetState() Actual: 5 Expected: State::CONNECTION_CLOSED Which is: 4 I will disable those as well. If we're not currently using this code, I strongly think we should delete it. If we need it again we can dig it out of history and fix it.
,
Oct 5 2016
brettw@: Sorry for the flaky tests - please feel free to mark all of these as flaky and/or disable them for now. xiyuan@: Please do not remove the code. We will be continuing work on the ProximityAuth component shortly. The original code was written by an intern who has left, but the rest of the team will be picking up her work once we finish with some higher priority issues. Thanks!
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e commit 08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e Author: brettw <brettw@chromium.org> Date: Thu Oct 06 17:52:08 2016 Disable ProximityAuthBluetoothLowEnergyWeavePacket*Test tests These tests are consistently flaky across platforms. BUG= 651246 Review-Url: https://codereview.chromium.org/2395923002 Cr-Commit-Position: refs/heads/master@{#423580} [modify] https://crrev.com/08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc [modify] https://crrev.com/08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e commit 08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e Author: brettw <brettw@chromium.org> Date: Thu Oct 06 17:52:08 2016 Disable ProximityAuthBluetoothLowEnergyWeavePacket*Test tests These tests are consistently flaky across platforms. BUG= 651246 Review-Url: https://codereview.chromium.org/2395923002 Cr-Commit-Position: refs/heads/master@{#423580} [modify] https://crrev.com/08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc [modify] https://crrev.com/08f4c9d91c0e2f917de2aa0e5b651f3fff38a06e/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc
,
Oct 27 2016
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Dec 12 2016
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dafc3e2f8edb161aa77cbd084ccb6b08b488e3df commit dafc3e2f8edb161aa77cbd084ccb6b08b488e3df Author: khorimoto <khorimoto@chromium.org> Date: Tue Dec 13 22:01:07 2016 De-flake BluetoothLowEnergyWeave* tests. The issue was that ProximityAuthBluetoothLowEnergyWeaveClientConnectionTest set up "test" factories but did not un-set them once the test was over. The result is that two other tests used these test factories in their tests, which caused failed assertions. BUG= 651246 ,672263 Review-Url: https://codereview.chromium.org/2574853002 Cr-Commit-Position: refs/heads/master@{#438305} [modify] https://crrev.com/dafc3e2f8edb161aa77cbd084ccb6b08b488e3df/components/proximity_auth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc [modify] https://crrev.com/dafc3e2f8edb161aa77cbd084ccb6b08b488e3df/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator_unittest.cc [modify] https://crrev.com/dafc3e2f8edb161aa77cbd084ccb6b08b488e3df/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_receiver_unittest.cc
,
Dec 13 2016
,
Mar 3 2017
,
Mar 3 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by brettw@chromium.org
, Sep 28 2016