New issue
Advanced search Search tips

Issue 651242 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Crash in ash::SystemTray::ActivateAndStartNavigation

Project Member Reported by ClusterFuzz, Sep 28 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6611991336845312

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  ash::SystemTray::ActivateAndStartNavigation
  ash::KeyEventWatcher::HandleKeyEvent
  ash::KeyEventWatcherAura::OnKeyEvent
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=420630:420810

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96KGz_FEh5tk_6JhGeNnkzRyEOFs0JO6-i3wDBFxoH-C4d2lsBkT1NYAeKtJQggm5wefdhhiMt1OcNSFpPPqXg6X90bWxcoSoNPTaB5zt9jcLDyIpGRvE00mfzCYD26NjVG3cT8RkqMX5_uhfNvYxi7RNZS4WQkZ3LKPrJd8k549pqkoM8?testcase_id=6611991336845312


Additional requirements: Requires Gestures

Issue manually filed by: mummareddy

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>CorrectResult
Labels: M-55 Te-Logged
Owner: osh...@chromium.org
Status: Assigned (was: Untriaged)
Author: oshima
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/d69e8cbbe0412fabce0c091e6d19d9ac9d1fea00
Time: Sat Sep 24 00:03:21 2016
Lines 796 of file system_tray.cc which potentially caused crash are changed in this cl (frame #3, "ash::SystemTray::ActivateAndStartNavigation").

Files key_event_watcher.cc, key_event_watcher_aura.cc are changed in this cl (and is part of stack frame #5, "ash::KeyEventWatcher::HandleKeyEvent")
Minimum distance from crash line to modified line: 0. (file: system_tray.cc, crashed on: 795, modified: 795).

Suspected Project: chromium
Labels: OS-Chrome
Status: Started (was: Assigned)
how can I run this test locally?
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bb40ba64accf3cdddb906a487f73b0f25afc49f

commit 2bb40ba64accf3cdddb906a487f73b0f25afc49f
Author: oshima <oshima@chromium.org>
Date: Thu Oct 06 15:49:12 2016

Add check to investigate the crash.

I run the clusterfuzz test locally but couldn't reproduce this crash. The crash can happen if the bubble gets closed after activation, so adding CHECK to investigate how that's happening.

BUG= 651242 

Review-Url: https://codereview.chromium.org/2392183002
Cr-Commit-Position: refs/heads/master@{#423547}

[modify] https://crrev.com/2bb40ba64accf3cdddb906a487f73b0f25afc49f/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/2bb40ba64accf3cdddb906a487f73b0f25afc49f/ash/common/system/tray/system_tray.h

mummareddy@, how can I find the latest results?
Status: Fixed (was: Started)
The crash should result in different stack. Let me close this. mummareddy@, please assign to me when we've got new crash in SystemTray
Project Member

Comment 7 by ClusterFuzz, Oct 8 2016

ClusterFuzz has detected this issue as fixed in range 423512:423881.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6611991336845312

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  ash::SystemTray::ActivateAndStartNavigation
  ash::KeyEventWatcher::HandleKeyEvent
  ash::KeyEventWatcherAura::OnKeyEvent
  
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=423512:423881

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96KGz_FEh5tk_6JhGeNnkzRyEOFs0JO6-i3wDBFxoH-C4d2lsBkT1NYAeKtJQggm5wefdhhiMt1OcNSFpPPqXg6X90bWxcoSoNPTaB5zt9jcLDyIpGRvE00mfzCYD26NjVG3cT8RkqMX5_uhfNvYxi7RNZS4WQkZ3LKPrJd8k549pqkoM8?testcase_id=6611991336845312


Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bb40ba64accf3cdddb906a487f73b0f25afc49f

commit 2bb40ba64accf3cdddb906a487f73b0f25afc49f
Author: oshima <oshima@chromium.org>
Date: Thu Oct 06 15:49:12 2016

Add check to investigate the crash.

I run the clusterfuzz test locally but couldn't reproduce this crash. The crash can happen if the bubble gets closed after activation, so adding CHECK to investigate how that's happening.

BUG= 651242 

Review-Url: https://codereview.chromium.org/2392183002
Cr-Commit-Position: refs/heads/master@{#423547}

[modify] https://crrev.com/2bb40ba64accf3cdddb906a487f73b0f25afc49f/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/2bb40ba64accf3cdddb906a487f73b0f25afc49f/ash/common/system/tray/system_tray.h

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
FYI - I found that SystemTray::ActivateAndStartNavigation() is called every time you press tab, even if the tray is already open, activate and has a view focused. I wonder if that could be related.

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78581ae9b930e09bb0640986eb693d703dde905c

commit 78581ae9b930e09bb0640986eb693d703dde905c
Author: warx <warx@chromium.org>
Date: Mon Apr 03 20:39:24 2017

cleanup: Remove the system tray bubble crash investigation CHECK

Changes:
Now that Clusterfuzz reports crash fixed in  crbug.com/702267 , it is time to remove the check induced in crrev.com/2392183002.

BUG= 702267 
BUG= 651242 
TEST=none

Review-Url: https://codereview.chromium.org/2789653002
Cr-Commit-Position: refs/heads/master@{#461523}

[modify] https://crrev.com/78581ae9b930e09bb0640986eb693d703dde905c/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/78581ae9b930e09bb0640986eb693d703dde905c/ash/common/system/tray/system_tray.h

Sign in to add a comment