Issue 651238 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	fgor...@chromium.org
Closed:	Dec 2016
Cc:	dougarnett@chromium.org petewil@chromium.org
Components:	UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug

Apply TaskQueue to RequestCoordinator interaction with its backing store

Project Member Reported by fgor...@chromium.org, Sep 28 2016

Issue description

Apply TaskQueue to RequestCoordinator interaction with its backing store.

The following interactions with the store should be turned into tasks:
* request removal
* changing request state
* marking request started
* marking request aborted
* marking request completed
* picking next request to execute
* cleaning up old/expired/failed requests

Comment 1 by fgor...@chromium.org, Sep 29 2016

Components: UI>Browser>Offline

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0674abb71a7737c42f368d6b68d81e86208012e3

commit 0674abb71a7737c42f368d6b68d81e86208012e3
Author: fgorski <fgorski@chromium.org>
Date: Sat Oct 01 01:57:24 2016

[Offline pages] Introduces TaskQueue to serialize tasks that asynchronously access SQLStore

* Adds a TaskQueue and Task interface
* Adds tests for TaskQueue.
* Introduces a core/ directory under components/offline_pages

BUG= 645522 ,  651238 
R=dimich@chromium.org

Review-Url: https://codereview.chromium.org/2359933007
Cr-Commit-Position: refs/heads/master@{#422269}

[modify] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/BUILD.gn
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/BUILD.gn
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task.cc
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task.h
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_queue.cc
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_queue.h
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_queue_unittest.cc
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/task_unittest.cc
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/test_task.cc
[add] https://crrev.com/0674abb71a7737c42f368d6b68d81e86208012e3/components/offline_pages/core/test_task.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a98a5ef6b896c298d56f941108ce8df56ef0fde

commit 1a98a5ef6b896c298d56f941108ce8df56ef0fde
Author: fgorski <fgorski@chromium.org>
Date: Sat Oct 01 14:44:44 2016

[Offline pages] Applying TaskQueue to RequestQueue::ChangeRequestsState

* Creates a task to change requests state with tests
* Updates how RequestQueue performs ChangeRequestsState
* Removes ChangeRequestsState from the store

BUG= 645522 ,  651238 

Review-Url: https://codereview.chromium.org/2372043002
Cr-Commit-Position: refs/heads/master@{#422316}

[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/change_requests_state_task.cc
[add] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/change_requests_state_task.h
[add] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/change_requests_state_task_unittest.cc
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_in_memory_store.cc
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_in_memory_store.h
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store.h
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store_sql.cc
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store_sql.h
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_store_unittest.cc
[modify] https://crrev.com/1a98a5ef6b896c298d56f941108ce8df56ef0fde/components/offline_pages/background/request_queue_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1608da81a4ab410f761786df0b6113afa5ce0cd

commit e1608da81a4ab410f761786df0b6113afa5ce0cd
Author: fgorski <fgorski@chromium.org>
Date: Thu Oct 06 06:21:09 2016

[Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue

* Switching the interface of RequestQueue/RequestStore::RemoveRequests
* Converting implementation to Task based: RemoveRequestsTask with tests.
* Removing most of old callbacks and typedefs

BUG= 645522 , 651238 

Review-Url: https://codereview.chromium.org/2373933003
Cr-Commit-Position: refs/heads/master@{#423448}

[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/BUILD.gn
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/BUILD.gn
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/change_requests_state_task_unittest.cc
[add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task.cc
[add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task.h
[add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_picker.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_picker.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_in_memory_store.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_in_memory_store.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_sql.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_sql.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/offline_store_types.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f70872409d6d8727bdba390c48fbe9c78de3c53

commit 8f70872409d6d8727bdba390c48fbe9c78de3c53
Author: fgorski <fgorski@chromium.org>
Date: Wed Oct 19 20:34:40 2016

[Offline pages] Introduction of MarkAttemptStartedTask with tests

* Creates MarkAttemptStartedTask with tests
* Adds RequestQueue::MarkAttemptStated with tests
* Calls RequestQueue::MarkAttemptStated from RequestCoordinator

BUG= 651238 

Review-Url: https://chromiumcodereview.appspot.com/2416083002
Cr-Commit-Position: refs/heads/master@{#426271}

[modify] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/mark_attempt_started_task.cc
[add] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/mark_attempt_started_task.h
[add] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/mark_attempt_started_task_unittest.cc
[modify] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/background/request_queue_unittest.cc
[modify] https://crrev.com/8f70872409d6d8727bdba390c48fbe9c78de3c53/components/offline_pages/offline_store_types.h

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c

commit 31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c
Author: fgorski <fgorski@chromium.org>
Date: Fri Oct 21 02:23:55 2016

[Offline pages] Add MarkAttemptAbortedTask to Request Queue

This patch:
* Generalizes and extracts Update Request Task,
* Adds mark attempt aborted task
* Adds tests for mark attempt aborted task
* Applies MarkAttemptAbortedTask in Task queue and request coordinator

BUG= 651238 

Review-Url: https://chromiumcodereview.appspot.com/2438503003
Cr-Commit-Position: refs/heads/master@{#426694}

[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/mark_attempt_aborted_task.cc
[add] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/mark_attempt_aborted_task.h
[add] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/mark_attempt_aborted_task_unittest.cc
[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/mark_attempt_started_task.cc
[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/mark_attempt_started_task.h
[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/request_queue_unittest.cc
[add] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/update_request_task.cc
[add] https://crrev.com/31c8a02e214dee8f11ae68f9a19f4eaf0b2cba1c/components/offline_pages/background/update_request_task.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1608da81a4ab410f761786df0b6113afa5ce0cd

commit e1608da81a4ab410f761786df0b6113afa5ce0cd
Author: fgorski <fgorski@chromium.org>
Date: Thu Oct 06 06:21:09 2016

[Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue

* Switching the interface of RequestQueue/RequestStore::RemoveRequests
* Converting implementation to Task based: RemoveRequestsTask with tests.
* Removing most of old callbacks and typedefs

BUG= 645522 , 651238 

Review-Url: https://codereview.chromium.org/2373933003
Cr-Commit-Position: refs/heads/master@{#423448}

[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/BUILD.gn
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/BUILD.gn
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/change_requests_state_task_unittest.cc
[add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task.cc
[add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task.h
[add] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/remove_requests_task_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_coordinator_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_picker.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_picker.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_in_memory_store.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_in_memory_store.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_sql.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_sql.h
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_store_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/background/request_queue_unittest.cc
[modify] https://crrev.com/e1608da81a4ab410f761786df0b6113afa5ce0cd/components/offline_pages/offline_store_types.h

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/594de46700a111e7f2f08594eb601854ece1790e

commit 594de46700a111e7f2f08594eb601854ece1790e
Author: dougarnett <dougarnett@chromium.org>
Date: Tue Nov 01 16:39:34 2016

[Offline Pages] Converts MarkAttemptCompleted to a Task

BUG= 651238 

Review-Url: https://codereview.chromium.org/2463713003
Cr-Commit-Position: refs/heads/master@{#429021}

[modify] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/mark_attempt_completed_task.cc
[add] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/mark_attempt_completed_task.h
[add] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/mark_attempt_completed_task_unittest.cc
[modify] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/mark_attempt_started_task.cc
[modify] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/request_queue.h
[modify] https://crrev.com/594de46700a111e7f2f08594eb601854ece1790e/components/offline_pages/background/request_queue_unittest.cc

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840

[Automated comment] removing mislabelled merge-merged-2840

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3113e19fb5a58ae8dd2bbc7af58c7584486120c0

commit 3113e19fb5a58ae8dd2bbc7af58c7584486120c0
Author: petewil <petewil@chromium.org>
Date: Fri Nov 11 19:29:49 2016

Request Picker task

We are refactoring the Background Loading system to use async tasks.
The advantage of this is that tasks can finish uninterrupted by other
tasks which might interfere with them (better correctness, get rid
of those pesky race conditions).

To avoid circular header file dependencies, I moved several results objects from request_queue.h to a new file, queue_results.h, and the rename ended up touching quite a few files.

This change refactors the RequestPicker to use a task object.

BUG= 651238 

Review-Url: https://codereview.chromium.org/2473553004
Cr-Commit-Position: refs/heads/master@{#431617}

[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/BUILD.gn
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/BUILD.gn
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/mark_attempt_completed_task.h
[add] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/pick_request_task.cc
[add] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/pick_request_task.h
[add] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/pick_request_task_factory.cc
[add] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/pick_request_task_factory.h
[rename] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/pick_request_task_unittest.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_coordinator.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_coordinator.h
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_coordinator_event_logger.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_coordinator_event_logger.h
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_coordinator_event_logger_unittest.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_coordinator_unittest.cc
[delete] https://crrev.com/020daf33b3af41464d3f75cabfa389e818badeaa/components/offline_pages/background/request_picker.cc
[delete] https://crrev.com/020daf33b3af41464d3f75cabfa389e818badeaa/components/offline_pages/background/request_picker.h
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_queue.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_queue.h
[add] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_queue_results.h
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/background/request_queue_unittest.cc
[modify] https://crrev.com/3113e19fb5a58ae8dd2bbc7af58c7584486120c0/components/offline_pages/core/task_queue.cc

Comment 11 by fgor...@chromium.org, Nov 11 2016

We still need a task for GetRequests and AddRequest on the Queue.

Comment 12 by fgor...@chromium.org, Nov 27 2016

Status: Started (was: Assigned)

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/298ed466951c8537b56a4a4a064ba47c59bc5993

commit 298ed466951c8537b56a4a4a064ba47c59bc5993
Author: fgorski <fgorski@chromium.org>
Date: Mon Nov 28 22:57:25 2016

[Offline pages] Adding GetRequestsTask to RequestQueue

This patch wraps the process of getting requests in a simple task
in order to ensure that getting requests can be serialized with
other tasks to prevent race conditions.

BUG= 651238 

Review-Url: https://codereview.chromium.org/2517383008
Cr-Commit-Position: refs/heads/master@{#434760}

[modify] https://crrev.com/298ed466951c8537b56a4a4a064ba47c59bc5993/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/298ed466951c8537b56a4a4a064ba47c59bc5993/components/offline_pages/background/get_requests_task.cc
[add] https://crrev.com/298ed466951c8537b56a4a4a064ba47c59bc5993/components/offline_pages/background/get_requests_task.h
[add] https://crrev.com/298ed466951c8537b56a4a4a064ba47c59bc5993/components/offline_pages/background/get_requests_task_unittest.cc
[modify] https://crrev.com/298ed466951c8537b56a4a4a064ba47c59bc5993/components/offline_pages/background/request_queue.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22733070dd04a7d43e7dc3140a73b7592530dae8

commit 22733070dd04a7d43e7dc3140a73b7592530dae8
Author: fgorski <fgorski@chromium.org>
Date: Tue Nov 29 09:28:02 2016

[Offline pages] Adding AddRequestTask to Request Queue

This patch adds AddRequestTask with its tests to ensure request queue
operations are properly sequenced.

BUG= 651238 

Review-Url: https://codereview.chromium.org/2527293002
Cr-Commit-Position: refs/heads/master@{#434938}

[modify] https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8/components/offline_pages/background/BUILD.gn
[add] https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8/components/offline_pages/background/add_request_task.cc
[add] https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8/components/offline_pages/background/add_request_task.h
[add] https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8/components/offline_pages/background/add_request_task_unittest.cc
[modify] https://crrev.com/22733070dd04a7d43e7dc3140a73b7592530dae8/components/offline_pages/background/request_queue.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb1a8a81fc8788f48529a653bb32c46e7cee9c36

commit cb1a8a81fc8788f48529a653bb32c46e7cee9c36
Author: fgorski <fgorski@chromium.org>
Date: Wed Nov 30 18:29:23 2016

[Offline pages] TaskQueue polishing

Applying changes to method names and documentation based on design
review of the TaskQueue.

BUG= 651238 
R=dougarnett@chromium.org,petewil@chromium.org

Review-Url: https://codereview.chromium.org/2535273003
Cr-Commit-Position: refs/heads/master@{#435347}

[modify] https://crrev.com/cb1a8a81fc8788f48529a653bb32c46e7cee9c36/components/offline_pages/core/task.h
[modify] https://crrev.com/cb1a8a81fc8788f48529a653bb32c46e7cee9c36/components/offline_pages/core/task_queue.cc
[modify] https://crrev.com/cb1a8a81fc8788f48529a653bb32c46e7cee9c36/components/offline_pages/core/task_queue.h

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa20953bbe09465c66ac135f987b9f8bbb383e94

commit aa20953bbe09465c66ac135f987b9f8bbb383e94
Author: fgorski <fgorski@chromium.org>
Date: Sat Dec 03 00:22:58 2016

[Offline pages] Switching ChangeRequestsStateTask to use RequestQueueStore::GetRequestsByIds

* Small refactoring to ChangeRequestsStateTask to use a more efficient
  method to query requests (which was not available at the time it was
  originally created).

BUG= 651238 

Review-Url: https://codereview.chromium.org/2541423002
Cr-Commit-Position: refs/heads/master@{#436096}

[modify] https://crrev.com/aa20953bbe09465c66ac135f987b9f8bbb383e94/components/offline_pages/background/change_requests_state_task.cc
[modify] https://crrev.com/aa20953bbe09465c66ac135f987b9f8bbb383e94/components/offline_pages/background/change_requests_state_task.h
[modify] https://crrev.com/aa20953bbe09465c66ac135f987b9f8bbb383e94/components/offline_pages/background/change_requests_state_task_unittest.cc

Comment 17 by fgor...@chromium.org, Dec 5 2016

Status: Fixed (was: Started)

This task is closed, but there are 2 additional tasks being worked on as part of  issue 670343 .

►

Issue 651238 link

Issue metadata

Apply TaskQueue to RequestCoordinator interaction with its backing store

Issue description

Comment 1 by fgor...@chromium.org, Sep 29 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Oct 1 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 1 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Oct 19 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 21 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 1 2016

Comment 8 Deleted

Comment 9 by dimu@google.com, Nov 4 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Nov 11 2016

Comment 10 Deleted

Comment 11 by fgor...@chromium.org, Nov 11 2016

Comment 11 Deleted

Comment 12 by fgor...@chromium.org, Nov 27 2016

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Nov 28 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Nov 29 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Nov 30 2016

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Dec 3 2016

Comment 16 Deleted

Comment 17 by fgor...@chromium.org, Dec 5 2016

Comment 17 Deleted

Sign in to add a comment