New issue
Advanced search Search tips

Issue 651225 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Full-screen app blocks appearing other tasks

Project Member Reported by khmel@chromium.org, Sep 28 2016

Issue description

Inner bug: b/31780038

There is support for Arc tasks which don't have window on creation
time.

 

Comment 1 by khmel@chromium.org, Sep 29 2016

Description: Show this description

Comment 2 by khmel@chromium.org, Sep 30 2016

Cl was landed to master crrev.com/2381713002

Comment 3 by khmel@chromium.org, Sep 30 2016

Labels: M-54 Merge-Request-54

Comment 4 by dimu@chromium.org, Oct 1 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7abc218716abb2890e68e57305dd2105ba9f1bf

commit a7abc218716abb2890e68e57305dd2105ba9f1bf
Author: khmel <khmel@chromium.org>
Date: Mon Oct 03 20:34:51 2016

[Merge-M54] arc: Show icon for the task created in background.

There is support for Arc tasks which don't have window on creation
time.

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

BUG=b/31780038
BUG= 651225 
TEST=Manually on device. Various cases with deferred launch, pinned
     non-pinned apps, switch to secondary user profile and back.
     In all cases we have shelf icon for apps, even if another Arc
     app is active in full screen. In case of switching to the
     secondary profile, there is no Arc icons, including those,
     which don't have window attached.

Review-Url: https://codereview.chromium.org/2381713002
Review-Url: https://codereview.chromium.org/2392603003
Cr-Original-Commit-Position: refs/heads/master@{#421833}
Cr-Commit-Position: refs/branch-heads/2840@{#627}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a7abc218716abb2890e68e57305dd2105ba9f1bf/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/a7abc218716abb2890e68e57305dd2105ba9f1bf/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
[modify] https://crrev.com/a7abc218716abb2890e68e57305dd2105ba9f1bf/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Comment 6 by khmel@chromium.org, Oct 3 2016

Labels: -Hotlist-Merge-Approved
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Will test and update on inner bug. Clsoing this 
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7abc218716abb2890e68e57305dd2105ba9f1bf

commit a7abc218716abb2890e68e57305dd2105ba9f1bf
Author: khmel <khmel@chromium.org>
Date: Mon Oct 03 20:34:51 2016

[Merge-M54] arc: Show icon for the task created in background.

There is support for Arc tasks which don't have window on creation
time.

TBR=reviewer@chromium.org
NOTRY=true
NOPRESUBMIT=true

BUG=b/31780038
BUG= 651225 
TEST=Manually on device. Various cases with deferred launch, pinned
     non-pinned apps, switch to secondary user profile and back.
     In all cases we have shelf icon for apps, even if another Arc
     app is active in full screen. In case of switching to the
     secondary profile, there is no Arc icons, including those,
     which don't have window attached.

Review-Url: https://codereview.chromium.org/2381713002
Review-Url: https://codereview.chromium.org/2392603003
Cr-Original-Commit-Position: refs/heads/master@{#421833}
Cr-Commit-Position: refs/branch-heads/2840@{#627}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a7abc218716abb2890e68e57305dd2105ba9f1bf/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
[modify] https://crrev.com/a7abc218716abb2890e68e57305dd2105ba9f1bf/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h
[modify] https://crrev.com/a7abc218716abb2890e68e57305dd2105ba9f1bf/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Sign in to add a comment