[PresentationAPI] Repeat call to PresentationRequest.getAvailability return undefined |
||||||||||||
Issue description
Reproducible on beta (54.0.2840.41) and head 55.0.2867.0.
To repro, go to dev console:
var A = new PresentationRequest('abc').getAvailability();
var B = new PresentationRequest('abc').getAvailability();
Expected:
B is a Promise
Actual:
B is undefined.
This will also repro:
var a = new PresentationRequest('xyz');
var p1 = a.getAvailability();
var p2 = a.getAvailability();
Expected:
p1 and p2 are both Promises
Actual:
p1 is a Promise; p2 is undefined.
Note this doesn't repro if the URLs are different.
,
Sep 28 2016
,
Sep 28 2016
,
Sep 28 2016
,
Oct 4 2016
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d984d26caeefead1e3268d562955d6e560fbcd39 commit d984d26caeefead1e3268d562955d6e560fbcd39 Author: mlamouri <mlamouri@chromium.org> Date: Thu Oct 06 16:09:58 2016 Asynchronously resolve getAvailability callbacks. BUG= 651216 R=mfoltz@chromium.org Review-Url: https://codereview.chromium.org/2397453002 Cr-Commit-Position: refs/heads/master@{#423553} [add] https://crrev.com/d984d26caeefead1e3268d562955d6e560fbcd39/content/browser/presentation/presentation_browsertest.cc [modify] https://crrev.com/d984d26caeefead1e3268d562955d6e560fbcd39/content/renderer/presentation/presentation_dispatcher.cc [modify] https://crrev.com/d984d26caeefead1e3268d562955d6e560fbcd39/content/test/BUILD.gn
,
Oct 6 2016
It might be too late but checking if we can make this to M54 because it could break some websites.
,
Oct 6 2016
I'd prefer to wait until M55, since we're cutting stable in less than a week and only taking high priority fixes. If you believe this will impact a large number of users feel free to push back.
,
Oct 7 2016
Fair enough. Keeping this open because it landed close to the branch point. Want to double check that the fix made it to M55.
,
Oct 8 2016
Branch revision is 423768 and the fix landed in 423553 so it should be in m55. Closing.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d984d26caeefead1e3268d562955d6e560fbcd39 commit d984d26caeefead1e3268d562955d6e560fbcd39 Author: mlamouri <mlamouri@chromium.org> Date: Thu Oct 06 16:09:58 2016 Asynchronously resolve getAvailability callbacks. BUG= 651216 R=mfoltz@chromium.org Review-Url: https://codereview.chromium.org/2397453002 Cr-Commit-Position: refs/heads/master@{#423553} [add] https://crrev.com/d984d26caeefead1e3268d562955d6e560fbcd39/content/browser/presentation/presentation_browsertest.cc [modify] https://crrev.com/d984d26caeefead1e3268d562955d6e560fbcd39/content/renderer/presentation/presentation_dispatcher.cc [modify] https://crrev.com/d984d26caeefead1e3268d562955d6e560fbcd39/content/test/BUILD.gn
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Mar 24 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by imch...@chromium.org
, Sep 28 2016