[DevTools] Runtime.evaluate with asyncAwait:true will crash if result wrapping failed |
|||||
Issue description
Repro:
InspectorTest.sendCommand("Runtime.evaluate", {
expression: "Promise.resolve(Symbol(123))",
returnByValue: true,
awaitPromise: true}, dumpErrorAndCompleTest);
,
Sep 29 2016
,
Sep 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a07b43e938d28c8151d4254385cd4efff6c7975e commit a07b43e938d28c8151d4254385cd4efff6c7975e Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Sep 30 05:43:10 2016 [DevTools] fix crash in wrapping result for async Runtime.evaluate BUG= chromium:651211 , chromium:650965 TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/2381113003 . Committed: https://crrev.com/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2 Cr-Original-Commit-Position: refs/heads/master@{#39844} Cr-Commit-Position: refs/branch-heads/2840@{#596} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a07b43e938d28c8151d4254385cd4efff6c7975e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
,
Sep 30 2016
,
Oct 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c9391d15ca7fd2f80d0f907c39f2765a20af8749 commit c9391d15ca7fd2f80d0f907c39f2765a20af8749 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Mon Oct 03 15:51:14 2016 [inspector] added a test for crash in wrapping async evaluate result BUG= chromium:651211 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2381693002 Cr-Commit-Position: refs/heads/master@{#39933} [modify] https://crrev.com/c9391d15ca7fd2f80d0f907c39f2765a20af8749/test/inspector/protocol-test.js [add] https://crrev.com/c9391d15ca7fd2f80d0f907c39f2765a20af8749/test/inspector/runtime/evaluate-async-with-wrap-error-expected.txt [add] https://crrev.com/c9391d15ca7fd2f80d0f907c39f2765a20af8749/test/inspector/runtime/evaluate-async-with-wrap-error.js
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a07b43e938d28c8151d4254385cd4efff6c7975e commit a07b43e938d28c8151d4254385cd4efff6c7975e Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Sep 30 05:43:10 2016 [DevTools] fix crash in wrapping result for async Runtime.evaluate BUG= chromium:651211 , chromium:650965 TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/2381113003 . Committed: https://crrev.com/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2 Cr-Original-Commit-Position: refs/heads/master@{#39844} Cr-Commit-Position: refs/branch-heads/2840@{#596} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/a07b43e938d28c8151d4254385cd4efff6c7975e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 29 2016