New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651188 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Fix and reenable page_cycler_v2 on Android Nexus6 WebView Perf

Project Member Reported by sullivan@chromium.org, Sep 28 2016

Issue description

These bots are new, and I think this failure has occurred since they were brought up.

Link to failing step log:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20%283%29/builds/138/steps/page_cycler_v2.tough_layout_cases/logs/stdio
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20%283%29/builds/138/steps/page_cycler_v2.intl_es_fr_pt-BR/logs/stdio

[ RUN      ] /tmp/tmp0LEPD3.html
MapFunctionError: Cannot read property 'asyncSliceGroup' of undefined
    at prepareTelemetryInternalEventPredicate (/tracing/metrics/system_health/loading_metric.html:187:34)
    at timeToFirstContentfulPaintMetric (/tracing/metrics/system_health/loading_metric.html:232:9)
    at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:425:5)
    at runMetrics (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)
[  FAILED  ] /tmp/tmp0LEPD3.html (2742 ms)
Traceback (most recent call last):
  File "/b/rr/tmpqw9WhU/w/src/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: MapFunctionError: Cannot read property 'asyncSliceGroup' of undefined
    at prepareTelemetryInternalEventPredicate (/tracing/metrics/system_health/loading_metric.html:187:34)
    at timeToFirstContentfulPaintMetric (/tracing/metrics/system_health/loading_metric.html:232:9)
    at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:425:5)
    at runMetrics (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
    at metricMapFunction (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
    at eval (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
    at mapSingleTraceWithResult (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/rr/tmpqw9WhU/w/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)

[  FAILED  ] http://elmundo.es/ (35850 ms)


Ned, is there an easy way just to disable for N6+webview?

 
Yes, we can override ShouldDisable to add arbitrary complex disabling logic.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d24c0c3e89fd212c84e352250f60f363217d19

commit d7d24c0c3e89fd212c84e352250f60f363217d19
Author: sullivan <sullivan@chromium.org>
Date: Thu Sep 29 02:53:27 2016

Disable page_cycler_v2 on N6 webview

BUG= 651188 

Review-Url: https://codereview.chromium.org/2378053004
Cr-Commit-Position: refs/heads/master@{#421730}

[modify] https://crrev.com/d7d24c0c3e89fd212c84e352250f60f363217d19/tools/perf/benchmarks/page_cycler_v2.py

Labels: -Pri-1 Pri-2
Labels: -Pri-2 Pri-1
Looks like my disable CL is incorrect. yolandyan: any idea how to disable?

https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20WebView%20Perf%20%283%29/builds/143


Owner: yolandyan@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22604afd6830644db46ca418756d0bf41af3c129

commit 22604afd6830644db46ca418756d0bf41af3c129
Author: yolandyan <yolandyan@chromium.org>
Date: Fri Sep 30 09:55:55 2016

Disable page cycler on Nexus 6 AOSP

BUG= 651188 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2379123002
Cr-Commit-Position: refs/heads/master@{#422073}

[modify] https://crrev.com/22604afd6830644db46ca418756d0bf41af3c129/tools/perf/benchmarks/page_cycler_v2.py

Comment 7 by zh...@chromium.org, Oct 3 2016

Labels: -Pri-1 Pri-2
Summary: Fix and reenable page_cycler_v2 on Android Nexus6 WebView Perf (was: page_cycler_v2 tests failing ONLY on Nexus6 WebView)
Owner: ksakamoto@chromium.org
Status: Assigned (was: Untriaged)
loading.mobile benchmark was reverted due to this error on Nexus5x / Nexus6 WebView perf bots.

Assigning myself. It looks like rendererHelper.mainThread was null.

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4716219b58d4069fc6686d3217d98278ad62ec7e

commit 4716219b58d4069fc6686d3217d98278ad62ec7e
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Dec 09 06:26:02 2016

Roll src/third_party/catapult/ 0b7222ff3..df2363501 (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0b7222ff3002..df2363501bd7

$ git log 0b7222ff3..df2363501 --date=short --no-merges --format='%ad %ae %s'
2016-12-08 ksakamoto ChromeRendererHelper treats Chrome_InProcRendererThread as main thread
2016-12-08 benjhayden Reland Replace ValueSetOutputFormatter with HistogramSetJsonOutputFormatter.

BUG= 671730 , 651188 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2568433002
Cr-Commit-Position: refs/heads/master@{#437484}

[modify] https://crrev.com/4716219b58d4069fc6686d3217d98278ad62ec7e/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17ed06fc0eb8ea831568682a4ed2be93ce329a44

commit 17ed06fc0eb8ea831568682a4ed2be93ce329a44
Author: ksakamoto <ksakamoto@chromium.org>
Date: Mon Dec 12 05:37:16 2016

Enable page_cycler_v2 and loading.mobile on webview

https://crrev.com/2558743002 fixed a bug that loading metric doesn't
work for webview traces. This patch re-enables page_cycler_v2 and
loading.mobile benchmarks on webview bots.

BUG= 651188 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2564773002
Cr-Commit-Position: refs/heads/master@{#437822}

[modify] https://crrev.com/17ed06fc0eb8ea831568682a4ed2be93ce329a44/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/17ed06fc0eb8ea831568682a4ed2be93ce329a44/tools/perf/benchmarks/page_cycler_v2.py

Status: Fixed (was: Assigned)

Sign in to add a comment