New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651187 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 660110



Sign in to add a comment

Make blockerbot more visible and reliable.

Project Member Reported by erikc...@chromium.org, Sep 28 2016

Issue description

https://bugs.chromium.org/p/chromium/issues/detail?id=595245#c37

blockerbot added Merge-TBD for an M-51 bug, which can't possibly be relevant.
 
It would also be helpful if the auto-posted comment had a link to submit bugs against blockerbot in case of mistakes. I had to dig around moma to find the contact.
Cc: mbarbe...@chromium.org mmoss@chromium.org amineer@chromium.org
Components: Tools>Stability>SheriffBot
Labels: -Pri-3 Pri-2
Owner: gov...@chromium.org
tl;dr - blockerbot.py was offline, it had no logging / alerting, we missed merging a RB-Stable bug as a result.  After noticing this, we turned it back on - but it went through and applied labels to tons of old bugs.  I've bulk edited those and fixed it back up.

We need to get blockerbot.py into a better state.  We might actually be able to just integrate this into sheriffbot; sending to the sheriffbot team to evaluate.  Please let me know if you need more context re: the purpose of blockerbot.py and I can provide it.

Comment 3 by gov...@chromium.org, Sep 28 2016

Cc: dimu@chromium.org lafo...@chromium.org

Comment 4 by gov...@chromium.org, Sep 28 2016

Cc: ananthak@chromium.org
I think I've taken a look at blockerbot before, but I always forget where its source lives. Could you point me to it?

In general I like the idea of integrating it into sheriffbot. From the use cases I remember for blockerbot, there are some new things we'd need to support in sheriffbot, but I think it'd be worth it. I want to take a closer look at what blockerbot does before I say so for sure.

Comment 7 by ananthak@google.com, Sep 28 2016

Cc: bustamante@chromium.org
+Richard who is interested in contributing to sheriffbot..

Comment 8 by mmoss@chromium.org, Sep 29 2016

Issue 651444 has been merged into this issue.

Comment 9 by mmoss@chromium.org, Sep 29 2016

Summary: Make blockerbot more visible and reliable. (was: blockerbot gives not-useful comments)
Updating subject to better reflect the general "blockerbot needs fixing" discussion.
Cc: hablich@chromium.org
Cc: gov...@chromium.org yangmuzi@google.com
Owner: mbarbe...@chromium.org
Blocking: 660110
Owner: ananthak@chromium.org
Anantha, would you mind assigning this to whoever was planning on doing the blockerbot port? I forgot to take a note of it during our meeting.
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git/+/3f74932631dfc0e4b4989aa857f731a95ba4f29b

commit 3f74932631dfc0e4b4989aa857f731a95ba4f29b
Author: mmoss <mmoss@google.com>
Date: Mon Nov 07 16:12:41 2016

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/62327a7bfb4c1eb436e5a212df5c94d381399f9e

commit 62327a7bfb4c1eb436e5a212df5c94d381399f9e
Author: mmoss <mmoss@google.com>
Date: Mon Nov 07 16:17:30 2016

Owner: mmoss@chromium.org
Cc: -amineer@chromium.org
No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck!

Sign in to add a comment