New issue
Advanced search Search tips

Issue 651182 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

LogDog should use a project's READ permission instead of its own.

Project Member Reported by d...@chromium.org, Sep 28 2016

Issue description

LogDog currently implements its own set of ACLs. However, projects have their own configuration that defines read access: https://github.com/luci/luci-py/blob/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/components/components/config/proto/project_config.proto#L12

LogDog should use this setting instead of its own.
 
Status: Available (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Comment 4 by hinoka@chromium.org, Mar 21 2018

In luci-logdog.cfg, there are two auth definitions: reader_auth_groups and writer_auth_groups.

In project.cfg, there is one auth definition: "access", which is the same as a reader group.

Proposal is to remove luci-logdog.cfg/reader_auth_group, and replace it with project.cfg/access, but also leave luci-logdog.cfg/writer_auth_group alone.  This means that read access is defined in project.cfg, while write access is defined in luci-logdog.cfg.  I think this makes sense. 

Comment 5 by d...@chromium.org, Mar 21 2018

+1, #4 is exactly what I had in mind.

Sign in to add a comment