Histogrammer in message loop is obsolete |
||
Issue descriptionThere are some very old histograms (dating back to 2008) logged in message_loop via the StartHistogrammer() method. These are only enabled via command line flag. These seem to be a precursor of the data that is in chrome://profiler. These should be cleaned up. Attaching to this bug, the kHexRangePrintingFlag flag was only for these histograms. We should just clean this flag up since it is basically unused and of dubious value.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/035eb12a2d163d3d3c9185f800acd3d800d56444 commit 035eb12a2d163d3d3c9185f800acd3d800d56444 Author: rkaplow <rkaplow@chromium.org> Date: Wed Sep 28 21:48:36 2016 Cleanup histograms from message loop, as well as kHexRangePrintingFlag. The message loop histograms are only accessible via command line so are not really that useful. We have similar data via profiler and traces. Note that this logic is very old, added by jar@ from the historical repo. Removed support for HistogramBase::kHexRangePrintingFlag, which was an available flag for creating histograms. The intention was to make chrome://histograms more readable, but was never really used. Other minor changes: - visual change to chrome://histograms (average -> mean). - made the flag comment a bit more friendly as part of the "make chrome reviews friendlier" effort :) BUG= 651169 Review-Url: https://codereview.chromium.org/2382503002 Cr-Commit-Position: refs/heads/master@{#421650} [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/base/message_loop/message_loop.cc [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/base/message_loop/message_loop.h [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/base/metrics/histogram.cc [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/base/metrics/histogram_base.cc [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/base/metrics/histogram_base.h [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/base/metrics/sparse_histogram.cc [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/chrome/common/chrome_switches.cc [modify] https://crrev.com/035eb12a2d163d3d3c9185f800acd3d800d56444/chrome/common/chrome_switches.h
,
Jan 18 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by rkaplow@chromium.org
, Sep 28 2016