Use of uninit value in PlatformNotificationServiceTest.DisplayPersistentNotificationMatches |
|||
Issue descriptionFrom r421510 - https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/1742 PlatformNotificationServiceTest.DisplayPersistentNotificationMatches (run #1): [ RUN ] PlatformNotificationServiceTest.DisplayPersistentNotificationMatches ==26269==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x1077c89f in CreateNotificationFromData chrome/browser/notifications/platform_notification_service_impl.cc:460:5 #1 0x1077d02d in DisplayPersistentNotification chrome/browser/notifications/platform_notification_service_impl.cc:341:31 #2 0x4d103ba in TestBody chrome/browser/notifications/platform_notification_service_unittest.cc:263:14
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4a1e893bd1444ebb84ac4944a23a01bb379dd64 commit b4a1e893bd1444ebb84ac4944a23a01bb379dd64 Author: thestig <thestig@chromium.org> Date: Wed Sep 28 20:24:37 2016 Fix uninit read in PlatformNotificationServiceTest. Do some cleanup as well. BUG= 651165 Review-Url: https://codereview.chromium.org/2381633002 Cr-Commit-Position: refs/heads/master@{#421625} [modify] https://crrev.com/b4a1e893bd1444ebb84ac4944a23a01bb379dd64/chrome/browser/notifications/platform_notification_service_impl.cc [modify] https://crrev.com/b4a1e893bd1444ebb84ac4944a23a01bb379dd64/chrome/browser/notifications/platform_notification_service_unittest.cc
,
Sep 28 2016
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0463eb5e689328081e71de001f621fefed5b737c commit 0463eb5e689328081e71de001f621fefed5b737c Author: awdf <awdf@google.com> Date: Thu Sep 29 16:25:55 2016 Give PlatformNotificationAction's scalar type field a default value - This fixes the underlying reason for the uninit warning in PlatformNotificationServiceTest.DisplayPersistentNotificationMatches by initializing the field in PlatformNotificationAction's constructor. BUG=599859, 651165 Review-Url: https://codereview.chromium.org/2381023002 Cr-Commit-Position: refs/heads/master@{#421840} [modify] https://crrev.com/0463eb5e689328081e71de001f621fefed5b737c/content/public/common/platform_notification_data.h
,
Oct 21 2016
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests No warning or failures on the tests |
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, Sep 28 2016