Harmony - add Retina control design info to the spec |
||||||
Issue descriptionCurrently buttons, textfields, and other controls in Harmony use 1px strokes everywhere, making them hard to see on Retina machines. The spec needs to include directions on how to draw these controls on Retina. From discussions with bettes@, the current thinking is a 1px stroke with a darker stroke color for Retina. That satisfies the 2x case - Windows allows 1.x and 2.x scale factors, which must also be taken into account in this design. Currently the spec mentions px, pt, and dp. dp will no longer be used. pt will be used for elements that scale, and px will be used for elements that do not scale. The spec must be reviewed to ensure that the proper terms are used wherever they appear.
,
Sep 30 2016
Hi bettes@, The red square is 1pt, not 1px. 1pt at 2x is 2px x 2px. What you are seeing is how Harmony buttons are being stroked in 1px no matter the scale factor. If you specify a 1pt stroke for buttons you'll get a 2px width that matches your red square. In the e-mail thread you said that you wanted a crisp 1px line at 2x, in which case you don't really want the stroke to match the red square. But to compensate for the lightness of the 1px line at 2x (it's essentially 0.5pt), we need to increase the darkness of that line. Is what I'm saying making sense?
,
Sep 30 2016
> Re-examining the bubbles in Mac Canary, the strokes on the textButtons are 0.5 px and not the requested 1px (red square in the attachment). To further clarify the problem with this statement, you cannot physically draw a 0.5px line. By definition, the thinnest a line can be is 1px. You can draw a 1px line at 0.5 gray to simulate a black 0.5px line, but a 0.5 px line is not possible to achieve.
,
Oct 1 2016
,
Oct 1 2016
Just to further drive home that this is not a Shiny Modern problem or a Mac problem, here is a screenshot of the bookmarks dialog on Windows. The scale factor is either 1.5x or 2x. You can see that the button strokes are 1px.
,
Oct 3 2016
Hey Jayson, Apologies for the confusion. I made the mistake of not converting my screenshots to the appropriate 72 ppi, thus my "red square" was not a true pixel. I've updated the spec with an increased alpha value of 0.20 for both 1x and 2x. I want to avoid having ratio-dependent specifications, if possible. That type of granular customization isn't very scalable so let's see where we land with the new specs. Thanks for addressing the concern. SPEC: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec#%2FSPEC-secondary-UI-04a-buttons-light-theme.png
,
Oct 5 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bettes@chromium.org
, Sep 30 201666.9 KB
66.9 KB View Download
102 KB
102 KB View Download