New issue
Advanced search Search tips

Issue 651138 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

with --secondary-ui-md, star highlight gets stuck after bookmark bubble is dismissed

Project Member Reported by est...@chromium.org, Sep 28 2016 
I think this is probably broken because I changed the anchor to be something besides the star view itself.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9

commit 65ebe03b5aad3a435abe4f1659f4cf82a0baafa9
Author: estade <estade@chromium.org>
Date: Thu Sep 29 20:41:35 2016

Fix bookmark bubble/star view highlighting for Harmony.

Also remove BrowserView::GetToolbarView() because it was redundant
with BrowserView::toolbar().

BUG= 651138 

Review-Url: https://codereview.chromium.org/2374253002
Cr-Commit-Position: refs/heads/master@{#421926}

[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/extensions/bookmark_override_browsertest.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/ime/ime_warning_bubble_view.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/keyboard_access_browsertest.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/location_bar/star_view_browsertest.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/network_profile_bubble_view.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/65ebe03b5aad3a435abe4f1659f4cf82a0baafa9/chrome/browser/ui/views/toolbar/toolbar_view.h

Comment 2 by est...@chromium.org, Sep 29 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment