Remove URLRequestJob::NotifyDone |
|||||
Issue descriptionRemoveURLRequestJob::NotifyDone mostly serves make the URLRequest API behave (For some weird value of "behave"). It posts a task to call URLRequestJob::CompleteNotifyDone on failure or cancel and sets done_ to true, to prevent double cancel / cancel after success. Notify on failure can go through the same path as notify on success, cancel behavior should be modified for issue 472771 , and that makes setting done_ to true moot. It does some other minor things as well, which would need to be worked out, but don't think this will be too hard to get rid of. We could just make an OnDone method, if we need to, which does whatever we still need.
,
Oct 11 2016
,
Oct 12 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 12 2017
,
May 16 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mmenke@chromium.org
, Oct 11 2016