Issue metadata
Sign in to add a comment
|
Can no longer view specific responsive sizes.
Reported by
z...@thirdinteractive.com,
Sep 28 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36 Steps to reproduce the problem: 1. Open any website and launch the inspector. 2. Set the responsive width to any size (for example: 1800px) 3. Press the "down" key. What is the expected behavior? Normally, I'd be able to adjust the width 1 pixel at a time. What went wrong? Ever since the new update, I'm no longer able to adjust the width pixel-by-pixel. Instead, the width jumps several pixels at a time. I can't even explicitly set the pixel width to something that's being skipped, since the browser will automatically skip down to a different size. Did this work before? Yes 09/27/2016 Chrome version: 53.0.2785.116 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0
,
Sep 28 2016
,
Sep 30 2016
That's a regression, which went unnoticed. Thank you for the bug report! We are going to fix this soon.
,
Oct 21 2016
Has there been any progress on this?
,
Oct 21 2016
Sorry, no progress so far, but this issue is on track.
,
Oct 21 2016
Eric, could you please take a look?
,
Oct 21 2016
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f5985ecef25664e1b6bba43b338683dd5d63c64 commit 2f5985ecef25664e1b6bba43b338683dd5d63c64 Author: luoe <luoe@chromium.org> Date: Wed Oct 26 04:00:49 2016 DevTools: fix rounding of scale in device mode While resizing the DevTools viewport to be smaller than the emulated device's screen size in responsive mode, _calculateAndEmulate() clamps the emulated screen size to preferredScaledWidth/Height(). The condition to do so checks whether the screen's dimensions are greater than the preferred-scaled dimensions. The sharp scale calculator in calculateFitScale() would find a scale nearby the precise value that would result in integer screen sizes. However, it was possible for the sharp scale to be greater than the actual scale, which resulted in a smaller preferredScaledWidth/Height() than was available. This edge case triggers the clamping condition, which led to inaccurate widths/heights that differed from user input. BUG= 651123 Review-Url: https://codereview.chromium.org/2449763002 Cr-Commit-Position: refs/heads/master@{#427583} [modify] https://crrev.com/2f5985ecef25664e1b6bba43b338683dd5d63c64/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae4bf8b7cae4ad6190ce8efadf39c28eed0d2cc8 commit ae4bf8b7cae4ad6190ce8efadf39c28eed0d2cc8 Author: luoe <luoe@chromium.org> Date: Wed Oct 26 23:33:11 2016 DevTools: add tests for device mode's responsive mode This adds tests that reflect changes after this was fixed: https://codereview.chromium.org/2449763002 BUG= 651123 Review-Url: https://codereview.chromium.org/2446113004 Cr-Commit-Position: refs/heads/master@{#427876} [add] https://crrev.com/ae4bf8b7cae4ad6190ce8efadf39c28eed0d2cc8/third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive-expected.txt [add] https://crrev.com/ae4bf8b7cae4ad6190ce8efadf39c28eed0d2cc8/third_party/WebKit/LayoutTests/inspector/device-mode/device-mode-responsive.html [modify] https://crrev.com/ae4bf8b7cae4ad6190ce8efadf39c28eed0d2cc8/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
,
Oct 27 2016
Verified this issue on Windows-10 using chrome latest Dev M56-56.0.2902.0 by following steps mentioned in the original comment. Observed the responsive width are able to decrease by 1 pixel as expected by pressing down key. Hence adding TE-Verified label.
,
Oct 27 2016
,
Oct 27 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed09e1e6d44727fef28a03ebb363734d1a998e81 commit ed09e1e6d44727fef28a03ebb363734d1a998e81 Author: luoe <luoe@chromium.org> Date: Thu Oct 27 23:01:00 2016 DevTools: fix rounding of scale in device mode While resizing the DevTools viewport to be smaller than the emulated device's screen size in responsive mode, _calculateAndEmulate() clamps the emulated screen size to preferredScaledWidth/Height(). The condition to do so checks whether the screen's dimensions are greater than the preferred-scaled dimensions. The sharp scale calculator in calculateFitScale() would find a scale nearby the precise value that would result in integer screen sizes. However, it was possible for the sharp scale to be greater than the actual scale, which resulted in a smaller preferredScaledWidth/Height() than was available. This edge case triggers the clamping condition, which led to inaccurate widths/heights that differed from user input. BUG= 651123 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2449763002 Cr-Commit-Position: refs/heads/master@{#427583} (cherry picked from commit 2f5985ecef25664e1b6bba43b338683dd5d63c64) Review-Url: https://codereview.chromium.org/2457883004 Cr-Commit-Position: refs/branch-heads/2883@{#347} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/ed09e1e6d44727fef28a03ebb363734d1a998e81/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
,
Oct 28 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by z...@thirdinteractive.com
, Sep 28 2016