New issue
Advanced search Search tips

Issue 651120 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 455744



Sign in to add a comment

URLRequestJob calls URLRequest::Cancel when entering suspend mode

Project Member Reported by mmenke@chromium.org, Sep 28 2016

Issue description

URLRequestJob calls URLRequest::Cancel when entering suspend mode.  The reason for this is that connections tend to be blackholed on network changes.

This can result in URLRequestJob signalling a read failure when there's no pending read, which is weird.  It also results in URLRequestJobs that are not going over the network failing when they shouldn't.

Before this issue is tackled, we should figure two things:
1)  Should QUIC requests be cancelled in this case?  It's unclear if QUIC recovers smoothly from this case or not.
2)  Should we change the error we're failing with?  Right now, we fail with ERR_ABORTED, which cancels top level navigations.  Seems like we should fail with ERR_NETWORK_SUSPENDED, and if Chrome wants to cancel the navigation instead of showing an error page in response, it's up to Chrome to do so, not the network stack.
 

Comment 1 by mmenke@chromium.org, Oct 20 2016

Owner: mmenke@chromium.org
Status: Assigned (was: Available)
Labels: -Type-Bug Type-Task

Sign in to add a comment