Remove URLRequest::is_pending |
|||
Issue descriptionOther than DCHECKs and tests, it's only used in two places: 1) ChromeResourceDispatcherHostDelegate, where we add extra throttles if it's false. This was assuming false meant "not started", but it actually means "not running", so we were incorrectly adding them if a request was completed, resulting in a crasher in some cases (See issue 640545), and just a second set of throttles in others. There's a CL out to remove this use. 2) ResourceLoader uses it to know if URLRequest::Cancel will call back into the ResourceLoader when invoked, so it doesn't need to do anything else. This use is also problematic (See issue 472771 for fun issues with URLRequest::Cancel). Because of 2), this should probably wait until after 472771 is fixed.
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0db6b84b050d52e0faa99136e35eb73009f6566b commit 0db6b84b050d52e0faa99136e35eb73009f6566b Author: Fady Samuel <fsamuel@chromium.org> Date: Wed Sep 06 18:36:21 2017 Surface synchronization: Use latest size for primary surface We were using the last size stored instead of the latest size provided to set the primary SurfaceInfo which was causing surfaces to get clipped when --enable-surface-synchronization is used. Bug: 651108 Change-Id: I55de6e0ebd14fbd1151c34762a3e7c9085d68c09 Reviewed-on: https://chromium-review.googlesource.com/653041 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#500019} [modify] https://crrev.com/0db6b84b050d52e0faa99136e35eb73009f6566b/content/renderer/browser_plugin/browser_plugin.cc [modify] https://crrev.com/0db6b84b050d52e0faa99136e35eb73009f6566b/content/renderer/render_frame_proxy.cc
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e64463959b3e0128c51a786ce513aca923257664 commit e64463959b3e0128c51a786ce513aca923257664 Author: Fady Samuel <fsamuel@chromium.org> Date: Wed Sep 06 23:51:44 2017 Surface synchronization: Simplify flags Add kEnableSurfaceSynchronization to the CommandLine if running in Mus mode. That way, we don't need to check IsRunningInMash all over the place. Bug: 651108 Change-Id: I386585347223f5e40f3bfdd0bfbd28a23f52ccc2 Reviewed-on: https://chromium-review.googlesource.com/653805 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#500137} [modify] https://crrev.com/e64463959b3e0128c51a786ce513aca923257664/content/browser/browser_main_loop.cc [modify] https://crrev.com/e64463959b3e0128c51a786ce513aca923257664/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/e64463959b3e0128c51a786ce513aca923257664/content/renderer/browser_plugin/browser_plugin.cc [modify] https://crrev.com/e64463959b3e0128c51a786ce513aca923257664/content/renderer/gpu/render_widget_compositor.cc [modify] https://crrev.com/e64463959b3e0128c51a786ce513aca923257664/content/renderer/render_frame_proxy.cc [modify] https://crrev.com/e64463959b3e0128c51a786ce513aca923257664/content/renderer/render_thread_impl.cc
,
May 16 2018
Still think this would be nice to do - will be easier once the network service ships, though.
,
Aug 23
|
|||
►
Sign in to add a comment |
|||
Comment 1 Deleted