New issue
Advanced search Search tips

Issue 651106 link

Starred by 1 user
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

New tests from https://crrev.com/2352083003 time out (itermittently) on Win10 Tests x64

Project Member Reported by lukasza@chromium.org, Sep 28 2016 
When https://crrev.com/2352083003 landed as r421287, it triggered failures on Win10 Tests x64 bot:

- build #4653 is the first red build - this is the build where r421287 has landed
- build #4658 is the first green build - this is where the revert has landed


The following tests were timing out on the bot:

NavigatingExtensionPopupBrowserTest.PageInSameExtension - all builds from #4653 to #4657

NavigatingExtensionPopupBrowserTest.PageInSameExtension - builds #4655 and #4656
NavigatingExtensionPopupBrowserTest.Webpage - builds #4655 and #4656


In case of all failures, the log didn't include any information (I wish I had retained the logging statements - https://codereview.chromium.org/2352083003/diff/140001/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc#newcode840 and https://codereview.chromium.org/2352083003/diff/120001/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc#newcode840).  The log only had the following:

NavigatingExtensionPopupBrowserTest.PageInSameExtension (run #1):
[ RUN      ] NavigatingExtensionPopupBrowserTest.PageInSameExtension
[4220:6088:0927/161637:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 297

FWIW, it seems that the dxva_video_decode_accelerator_win.cc appears in other tests/places in the log (both for passing and failing tests) and so is unlikely to be related to this particular timeout.

Comment 2 by lukasza@chromium.org, Sep 28 2016 

When trying to repro on Windows 7, I was surprised to get a timeout with the following error:

[ RUN      ] NavigatingExtensionPopupBrowserTest.PageInSameExtension
[7220:15760:0928/093148:INFO:media_foundation_video_encode_accelerator_win.cc(287)] Windows versions earlier than 8 are not supported.

This seems to be different though, than the failures seen earlier on Win10 Tests x64.

Comment 3 by lukasza@chromium.org, Sep 28 2016 

It seems that in the repro of the problematic timeout / hang, the following things happen:

1. Full test for GET method completes successfully (i.e. the call to TestPopupNavigationViaGet completes)

2. The NavigatingExtensionPopupBrowserTest.PageInSameExtension tries to do the next step of the test and calls TestPopupNavigationViaPost.  This ends up calling TestPopupNavigation and OpenPopup - this hangs here:

  WebContents* OpenPopup(int index) {
    ResultCatcher catcher;
    content::WindowedNotificationObserver popup_observer(
        content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
        content::NotificationService::AllSources());
    GetBrowserActionsBar()->Press(index);
    popup_observer.Wait();  <- THIS IS WHERE THE TEST HANGS (ON 2nd SUBTEST / AFTER POPUP WAS ALREADY SHOWN + HIDDEN ONCE BEFORE)
    EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();

Comment 4 by lukasza@chromium.org, Sep 29 2016

Status: Fixed (was: Started)
No issues seen after r421645 landed - closing as fixed.
►

Sign in to add a comment