Report protocol errors |
|||
Issue descriptionFor example, if DOM::querySelector() is given a bad selector, the callback is never invoked because the reply message doesn't have a "result" property (only "error"). We should report errors like this to the user somehow.
,
Nov 29 2016
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c99aca28e9e59194c153ea13b85c1d7763467fb commit 0c99aca28e9e59194c153ea13b85c1d7763467fb Author: tmarek <tmarek@google.com> Date: Wed Nov 30 13:26:52 2016 If there is an error in a devtools API call, invoke the callback with a TYPE_NULL value result and log the error message. This is a partial fix because it at least allows detecting that there was an error, while keeping source-code-level backwards compatibility. BUG= 651082 Review-Url: https://codereview.chromium.org/2539833002 Cr-Commit-Position: refs/heads/master@{#435240} [modify] https://crrev.com/0c99aca28e9e59194c153ea13b85c1d7763467fb/headless/lib/browser/devtools_api/domain_cc.template [modify] https://crrev.com/0c99aca28e9e59194c153ea13b85c1d7763467fb/headless/lib/browser/headless_devtools_client_impl.cc [modify] https://crrev.com/0c99aca28e9e59194c153ea13b85c1d7763467fb/headless/lib/headless_devtools_client_browsertest.cc
,
Dec 1 2016
Thanks! Let's close this for now and track the promisification (which will provide richer error information) in bug 670268 . |
|||
►
Sign in to add a comment |
|||
Comment 1 by skyos...@chromium.org
, Nov 29 2016