New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651079 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Include addresses with the getdetailsforsavecard Payments RPC.

Project Member Reported by jdonnelly@chromium.org, Sep 28 2016

Issue description

These addresses will be used by Payments to determine the correct legal
documents to show the user and to verify that the addresses are valid
for their purposes (and thus won't fail on any subsequent save).
 
Cc: zkoch@chromium.org
https://codereview.chromium.org/2349033002/

Include addresses with the getdetailsforsavecard Payments RPC.

These addresses will be used by Payments to determine the correct legal
documents to show the user and to verify that the addresses are valid
for their purposes (and thus won't fail on any subsequent save).

Names and phone numbers are removed from the addresses before uploading
since they are not useful for these purposes.

BUG=535784
Committed: https://crrev.com/da7eb69a380d53eec42cc4e620e55b78e5d6fa82
Committed: https://crrev.com/005d6cd78d14cb1d68a92a0d8dd9a98595b54d80
Cr-Original-Commit-Position: refs/heads/master@{#420409}
Cr-Commit-Position: refs/heads/master@{#420893}
Status: Fixed (was: Started)
Labels: Merge-Request-54

Comment 4 by dimu@chromium.org, Sep 29 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be023346b6939f20fafbed8612f1bbf4bdf6ca52

commit be023346b6939f20fafbed8612f1bbf4bdf6ca52
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Thu Sep 29 17:02:23 2016

Include addresses with the getdetailsforsavecard Payments RPC.

These addresses will be used by Payments to determine the correct legal
documents to show the user and to verify that the addresses are valid
for their purposes (and thus won't fail on any subsequent save).

Names and phone numbers are removed from the addresses before uploading
since they are not useful for these purposes.

BUG=535784

Committed: https://crrev.com/da7eb69a380d53eec42cc4e620e55b78e5d6fa82
Review-Url: https://codereview.chromium.org/2349033002
Cr-Original-Commit-Position: refs/heads/master@{#420409}
Cr-Commit-Position: refs/heads/master@{#420893}
(cherry picked from commit 005d6cd78d14cb1d68a92a0d8dd9a98595b54d80)

Review URL: https://codereview.chromium.org/2376323003 .

Cr-Commit-Position: refs/branch-heads/2840@{#580}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/be023346b6939f20fafbed8612f1bbf4bdf6ca52/components/autofill/content/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/be023346b6939f20fafbed8612f1bbf4bdf6ca52/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/be023346b6939f20fafbed8612f1bbf4bdf6ca52/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/be023346b6939f20fafbed8612f1bbf4bdf6ca52/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/be023346b6939f20fafbed8612f1bbf4bdf6ca52/components/autofill/core/browser/payments/payments_client.h
Labels: M-54
If there is no pending work, please remove Merge-Approved-54 label.
Labels: -Hotlist-Merge-Approved -Merge-Approved-54
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment