New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651078 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Stop using Syzygy on the official builds.

Project Member Reported by sebmarchand@chromium.org, Sep 28 2016

Issue description

Now that we're shipping the PGO builds it doesn't really make sense to keep instrumenting the builds from the 'win' builder with Syzygy (this builder could probably disappear as well). 
 

Comment 1 by mmoss@chromium.org, Sep 28 2016

Are all channels PGO now? I believe there's already a bug to get rid of the old win builders when that happens.
Cc: waff...@chromium.org
+waffles@ to make sure that we're really shipping PGO to all the Win & Win64 channels.

They should be, we're shipping the PGO builds to all the channels in M54+ (if we don't then we should). 

We need to keep the win builders as long as we support M53.
See crbug.com/640409 and crbug.com/625234 : We're shipping PGO to the Canary channels for x86 and x64.

Comment 4 by mmoss@chromium.org, Sep 28 2016

FYI, Issue 629603 is the bug about getting rid of the old builders.
Components: Infra>Client>Chrome>Release
Labels: -Pri-3 M-54 OS-Windows Pri-2
This is the right thing to do, but please hold off until after M54 has been promoted to Stable.  We still need to produce non-PGO x86 builds for M53.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c0a80ee66d17702b05f21553c4d4e974b89d471

commit 6c0a80ee66d17702b05f21553c4d4e974b89d471
Author: sebmarchand <sebmarchand@chromium.org>
Date: Wed Sep 28 19:05:29 2016

Add a chrome_official_syzyasan_builder target.

This will ease the removal of the Syzygy optimization targets.

BUG= 651078 

Review-Url: https://codereview.chromium.org/2379683002
Cr-Commit-Position: refs/heads/master@{#421595}

[modify] https://crrev.com/6c0a80ee66d17702b05f21553c4d4e974b89d471/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/e49a130068701472d5a8922c05c4722a555b146d

commit e49a130068701472d5a8922c05c4722a555b146d
Author: sebmarchand <sebmarchand@google.com>
Date: Wed Sep 28 19:09:34 2016

Status: Assigned (was: Untriaged)
We're now shipping M54, time to remove the Syzygy stuffs?
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/96975ce23297e519e6e8de1c83800ded27ec3546

commit 96975ce23297e519e6e8de1c83800ded27ec3546
Author: sebmarchand <sebmarchand@google.com>
Date: Mon Oct 17 14:10:06 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/c7c50660165325c7b6c1a85c1326fc4309d02c6a

commit c7c50660165325c7b6c1a85c1326fc4309d02c6a
Author: sebmarchand <sebmarchand@google.com>
Date: Mon Oct 17 16:52:26 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/4fc643596a74ba581971b4e755059118e6d57a43

commit 4fc643596a74ba581971b4e755059118e6d57a43
Author: sebmarchand <sebmarchand@google.com>
Date: Mon Oct 17 21:07:20 2016

Status: Fixed (was: Assigned)

Comment 16 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment