The ContextMenu related code for the suggestions has had a bit more testing and bugfixes done on it, for issues that can be reproduced with the tiles. Both should use the same code as they are pretty much doing the same thing.
Issue 647592 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99f920d4c9724872f6176b9c71eb7b198ed3b9ea commit 99f920d4c9724872f6176b9c71eb7b198ed3b9ea Author: dgn <dgn@chromium.org> Date: Wed Oct 26 11:35:51 2016 [NTP] Merge the context menu code for NTP tiles and suggestions Adds a ContextMenuHandler class that takes care of creating the menu and triages the item clicks, allowing to remove that from the NTPManager and the Snippet ViewHolder. Also adds the possibility to disable touch on the legacy ScrollView, so that we can disable scrolling while the context menu is shown. BUG= 651045 Review-Url: https://codereview.chromium.org/2452543005 Cr-Commit-Position: refs/heads/master@{#427669} [add] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/java_sources.gni [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
Comment 1 by fi...@chromium.org
, Sep 28 2016