Clarify "apply_issue.py" usage with Gerrit |
||||||
Issue descriptionThere is some confusion right now with PG dogfooders and "git cl patch" / "apply_issue.py". The download link on PG CLs details how to get this functionality but there is (AFAIK) no tool in depot_tools to do this. We should either output messages from those two tools saying this is unsupported in Gerrit, or add Gerrit support to them.
,
Sep 28 2016
You are right, it works. I made a mistake when trying to test "git cl patch" which is why it failed for me. Changing the summary to only address "apply_issue.py". Personally I always used to use apply_issue.py when dealing with Rietveld. Changing apply_issue.py to say unsupported for Gerrit and to use "git cl patch" instead will be a good enough solution IMO.
,
Sep 28 2016
,
Sep 28 2016
Well, apply_issue claims to apply issues 'for rietveld'. What arguments have you supplied to it? I'm trying to understand under which circumstances could apply_issue detect it's being used for Gerrit and exit with a good message.
,
Sep 28 2016
Yea I took a look at it as well and could not come up with an easy way to detect it's Gerrit without having access to the stuff in git_cl.py I had earlier tried to use it the same way I did for Rietveld CLs: apply_issue.py -i 2741 Admittedly this is not critical because as you said 'apply_issue.py --help' says 'Applies an issue from Rietveld'. This can either be a P3 or punted to a different Milestone.
,
Sep 29 2016
,
Sep 29 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2017
"git cl try" is the canonical way to apply issues from Gerrit. apply_issue.py will be entirely deleted in the near future. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by andyb...@chromium.org
, Sep 28 2016Labels: Milestone-Fishfood
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)