New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 651022 link

Starred by 1 user
Status: Fixed
Owner:
pkasting@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Tabstrip shouldn't mask active tab bounds for bottom divider if active tab is invisible

Reported by vku...@etouch.net, Sep 28 2016 
Chrome Version:54.0.2840.41 (Official Build) aeb8895aa4becddb1526af10d1e67495713b6c1a-refs/branch-heads/2840@{#557} (32/64-bit)
OS: Windows (7,8,8.1,10)

What steps will reproduce the problem?
(1)Launch chrome and click on 'restore down' button from top right.
(2)Resize the window towards left from R.H.S of browser window.
(3)Now open multiple ntp and observe the black border line of tabstrip.

Actual: Black border line of tabstrip appears to be chopped after opening multiple ntp

Expected: Black border line of tabstrip should be displayed properly even after opening multiple ntp

This is a regression issue broken in 'M53' and will soon update otehr info.

Comment 1 by vku...@etouch.net, Sep 28 2016

Labels: hasbisect OS-Linux
Owner: pkasting@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 53.0.2748.0 
Bad Build:  53.0.2750.0

Narrow bisect
https://chromium.googlesource.com/chromium/src/+log/59d51f9a4cea0fd3d0c27eaf069442b9f556ea9a..d1b22fc961b1a2677c32f61a2a5640850b66adb9?pretty=fuller&n=30

Suspecting: 396304 ?
Kindly help to re-assign, if your changes are not cause for this issue. 

Note: Issue not seen on Mac OS.
Actual_Tabstrip.mp4
373 KB View Download
Expected_Tabstrip.mp4
291 KB View Download

Comment 2 by pkasting@chromium.org, Sep 28 2016

Labels: -Pri-1 -hasbisect -M-53 OS-Chrome Pri-2
Summary: Tabstrip shouldn't mask active tab bounds for bottom divider if active tab is invisible (was: Regression:Black border line of tabstrip appears to be chopped after opening multiple ntp.)
This is basically a specific case of the more general  bug 588261 .

Here the active tab is hidden and masking its bounds off in the tabstrip code that draws the bottom divider is thus wrong.  The obvious fix is to check whether this tab will be drawn before doing that.

It would be nice to avoid being in a scenario where the active tab is invisible to begin with, but I don't know how we can ensure that with our other system constraints.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c876f4a1c3d5cf0a8ef48f3ac18fcf2406633fb4

commit c876f4a1c3d5cf0a8ef48f3ac18fcf2406633fb4
Author: sangwoo.ko <sangwoo108@gmail.com>
Date: Mon Mar 12 19:09:04 2018

Don't clip tool bar border if active tab is invisible

Bug:  651022 
Change-Id: I95d405ca9be1747abfe24f68f0837ed5981571ed
Reviewed-on: https://chromium-review.googlesource.com/958783
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542556}
[modify] https://crrev.com/c876f4a1c3d5cf0a8ef48f3ac18fcf2406633fb4/chrome/browser/ui/views/tabs/tab_strip.cc

Comment 4 by pkasting@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)

Comment 5 by vku...@etouch.net, Mar 14 2018 

Update:

Rechecked again and above issue is still reproducible on latest canary version 67.0.3370.0 (Official Build) on Windows (7,8,8.1,10)

Note: Issue not seen on Linux(14.04) OS

Please refer attached screencast
Actual_Canary.mp4
466 KB View Download

Comment 6 by pkasting@chromium.org, Mar 14 2018 

The issue in comment 5 is different from this bug, which is about cases where the active tab is invisible due to being positioned too far to the right to appear in the visible tabstrip.

I don't know whether there's already a bug on file for the issue you're reporting; I would look for one or file a new one.
►

Sign in to add a comment