New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651020 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
(currently inactive on Chromium)
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily background page gets scrolled down on pressing ‘Cmd + P’.

Reported by yfulgaon...@etouch.net, Sep 28 2016

Issue description

Chrome Version : 55.0.2873.4 (Official Build) fca4965da4443b4daed880fca6c788d4492ec56e-refs/branch-heads/2873@{#6} (32/64-bit)
OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://terms page.
2. Now scroll down to the middle of page and press ‘Cmd + P’.
3. Observe the vertical scroll bar in the background.

Actual : Unnecessarily background page gets scrolled down on pressing ‘Cmd + P’.
Expected : The background page should not get scrolled down on pressing ‘Cmd + P’.

This is a regression issue broken in ‘M-55’, below is the Manual Regression and will soon update bisect info.
Good build : 55.0.2860.0
Bad build : 55.0.2861.0
 
Actual_print.mov
6.3 MB Download
Expected_print.mov
6.7 MB Download
Cc: brajkumar@chromium.org
Components: Blink>Scroll
Labels: -hasbisect hasbisect-per-revision
Owner: skobes@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:55.0.2860.0(Revision: 418438).
Bad build: 55.0.2861.0(Revision: 418732).

You are probably looking for a change made after 418714 (known good), but no later than 418715 (first known bad).

CHANGELOG URL:
-----------------
https://chromium.googlesource.com/chromium/src/+log/02a4849687aa7a52e3af8959484f7f8b6b9335cf..73693c4b2eb516e55b700c0317b38d672a0bdb29

From the CL above, assigning the issue to the concern owner 

@skobes - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Owner: ymalik@chromium.org
Status: Started (was: Assigned)
Looking into this...
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32628627dac02e25eb29924fa9b39b399d694547

commit 32628627dac02e25eb29924fa9b39b399d694547
Author: ymalik <ymalik@chromium.org>
Date: Mon Oct 17 19:49:52 2016

Disable scroll anchoring when in printing mode

BUG= 651020 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2417683002
Cr-Commit-Position: refs/heads/master@{#425756}

[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/components/printing/renderer/print_web_view_helper.cc
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/32628627dac02e25eb29924fa9b39b399d694547/third_party/WebKit/Source/core/paint/TextPainterTest.cpp

Comment 4 by ymalik@chromium.org, Oct 17 2016

Status: Fixed (was: Started)

Comment 5 by ymalik@chromium.org, Oct 17 2016

Labels: Hotlist-Input-Dev

Sign in to add a comment