New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 651001 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 660496
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Compat



Sign in to add a comment

hash of opener window can not be changed during unload

Reported by zboron.l...@gmail.com, Sep 28 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.34 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. main page opens child page in new tab
2. child page is closed and on unload event it tries to change location.hash of main page
3. main page hash is not changed

What is the expected behavior?
In chrome 53 and lower, hash in main window was changed.

What went wrong?
In chrome 54 hash in main window is not changed.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes chrome 53

Does this work in other browsers? N/A 

Chrome version: 54.0.2840.34  Channel: beta
OS Version: ubuntu 14.04
Flash Version: Shockwave Flash 23.0 r0

This is most likely result of change in 54, that prevents navigation during unload. However, in this case navigation is done in another window/tab which remains open. There is no navigation in unloaded window.

Should navigations in other windows/tabs be prevented as well?
 
Cc: tkonch...@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Linux 14.04 chrome version 54.0.2840.41 - opened yahoo.com and opened a link in new tab and closed the tab. Observed no change in the main page on closing the second tab

Could you please upgrade to latest beta and see if issue still exists. If yes please provide us the URL where you are facing the issue
This happens when page you open tries to change hash of original page during unload. yahoo.com does not do that.

1. page A (http://example.com/#firstHash) opens page B (http://example.com/sample)
2. user closes page B
3. unload handler in page B tries to change location of page A to http://example.com/#samplePageClosed

In past this would work, but since chrome 54 cancels navigation during unload, page A hash is not changed.

My question is whether this change should also affect navigation in tabs that are not being unloaded if navigation was initiated from another page during unload?
Labels: -Needs-Feedback Needs-Bisect
Cc: hdodda@chromium.org
Labels: -Needs-Bisect Needs-Feedback
@zboron.lukas -- Could you please provide sample test cases and test file of unload handler in page B. 
And also if possible please provide us screen recording of the issue which would help us in triaging further.

Note: Removing Needs Bisect label as of now.
Thanks !

I have created simple test case.

1. unzip and deploy on any server
2. browse index.html, eg. http://localhost:8080/index.html
3. click "open child" link
4. close child page

Main page displays alert in chrome 53, nothing happens in chrome 54.
navigation-sample.zip
952 bytes Download
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 24 2016

Labels: -Needs-Feedback Needs-Review
Owner: hdodda@chromium.org
Thank you for providing more feedback. Adding requester "hdodda@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review Needs-Feedback
Owner: ----
@zboron-- 

Unable to reproduce the issue on Ubuntu 14.04 using chrome stable M54 #54.0.2840.71 on following the steps given in comment #6.

Attached screencast for reference.

Thanks !
651001.ogv
629 KB View Download
Components: Blink>Loader
In the attached video, page is accessed by file:// protocol. Page needs to be deployed to any http server and accessed by http:// to work as described.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 17 2016

Labels: -Needs-Feedback Needs-Review
Owner: hdodda@chromium.org
Thank you for providing more feedback. Adding requester "hdodda@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: UI>Browser>Navigation
Labels: -Pri-2 Pri-3
Owner: lfg@chromium.org
Status: Untriaged (was: Unconfirmed)
Indeed zboron your hunch was correct. I bisected down to
https://chromium.googlesource.com/chromium/src/+log/a8a40f8baa6a8cdf727332f3ef398570a59d631d..aaad992eef8e8c1e879f72afd9dabb05d3855e67

lfg could you please take a look at this issue?
Status: Assigned (was: Untriaged)

Comment 14 by creis@chromium.org, Nov 22 2016

I think this is already being tracked in  issue 660496 ?
Mergedinto: 660496
Status: Duplicate (was: Assigned)
Ah yes, didn't see that one. Thanks creis!

Sign in to add a comment