New issue
Advanced search Search tips

Issue 650982 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Chrome ELF should use a product-specific registry location

Project Member Reported by grt@chromium.org, Sep 28 2016

Issue description

This was discussed as desirable in  issue 577820  but deemed too difficult to justify. It will become much less difficult after some other work I have planned.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4cab81eb31fc479ab7583d6cbfab9288750aeb5

commit b4cab81eb31fc479ab7583d6cbfab9288750aeb5
Author: grt <grt@chromium.org>
Date: Fri Mar 31 06:58:43 2017

Remove use of PRODUCT_STRING_PATH in chrome_elf.

The blacklist and browser security code now use install_static's
GetRegistryPath function to get the brand- and install mode-specific
path to a spot in the registry for various data stuffage.

BUG= 577820 , 650982 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2760853002
Cr-Commit-Position: refs/heads/master@{#461064}

[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome/browser/BUILD.gn
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome/browser/win/chrome_elf_init.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome/browser/win/chrome_elf_init_unittest.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/BUILD.gn
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/blacklist/blacklist.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/blacklist/test/blacklist_test.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/chrome_elf_constants.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/chrome_elf_constants.h
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/chrome_elf_security.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/chrome_elf_util_unittest.cc
[modify] https://crrev.com/b4cab81eb31fc479ab7583d6cbfab9288750aeb5/chrome_elf/run_all_unittests.cc

Comment 2 by grt@chromium.org, Mar 31 2017

Status: Fixed (was: Assigned)

Sign in to add a comment