Issue metadata
Sign in to add a comment
|
Regression: Overlapping of button on text is seen in 'report an issue' overlay after changing browser language.
Reported by
vku...@etouch.net,
Sep 28 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:55.0.2873.3 (Official Build)714c807de9a9710084add5fddbaa72d02a91096e-refs/branch-heads/2873@{#4} (32/64-bit) OS:Windows (7,8,8.1,10) What steps will reproduce the problem? (1)Launch chrome, navigate to chrome://md-settings/manageLanguages page and select 'Hindi' or any language from 'All languages' list. (2)Click on iron icon of hindi and select 'disply google chrome..' option, relauch the browser. (3)Navigate to chrome://md-settings/ click on iron icon (menu) and click on 'About chrome' option. (4)Now click on 'report an issue' button and observe the overlay. Actual: Overlapping of button on text is seen in 'report an issue' overlay after changing browser language. Expected: No such overlapping should be seen in 'report an issue' overlay after changing browser language. This is a regression issue broken in 'M55' and will soon update other info.
,
Sep 28 2016
Using the per-revision bisect providing the bisect results, Good build: 55.0.2853.0 (Revision: 416812). Bad build: 55.0.2854.2 (Revision: 417283). You are probably looking for a change made after 416969 (known good), but no later than 416970 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/453c8d7ab0f3efa78d698627227951b0a9b6d27f..3b949a8022d2f4f6f89e6114a52befee39f40c2e Adding RB Label as this is a recent Regression. @ellyjones -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You.
,
Oct 3 2016
Issue is still reproducible on the latest canary(55.0.2879.0) on Windows-10. ellyjones@: Please take a look at this.
,
Oct 5 2016
Fix just landed in trunk (https://codereview.chromium.org/2388773002/). TE, can you please verify?
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf commit a8a4af9d344cb3ff20caa5f07c4f69903dec88bf Author: ellyjones <ellyjones@chromium.org> Date: Wed Oct 05 13:53:38 2016 feedback: fix buttons overlapping text in long-text locales Since the ok/cancel buttons had "position: absolute", they would be positioned over the privacy text if the privacy text happened to be longer than it is in English. This change: 1) Makes the bottom buttons not use "position: absolute", which seems like it was only intended to apply to the "window control" buttons; 2) Makes the dialog taller, since the non-absolute buttons now can't overlap the text, which they previously did to save height. Note that this design is still fairly brittle; if locales have a much shorter privacy text, there'll be significant whitespace between the text and the bottom buttons, and if a locale has much longer text, the dialog will gain a scroll bar, which looks pretty ugly. BUG= 650978 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2388773002 Cr-Commit-Position: refs/heads/master@{#423148} [modify] https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf/chrome/browser/resources/feedback/css/feedback.css [modify] https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf/chrome/browser/resources/feedback/html/default.html [modify] https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf/chrome/browser/resources/feedback/js/event_handler.js
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf commit a8a4af9d344cb3ff20caa5f07c4f69903dec88bf Author: ellyjones <ellyjones@chromium.org> Date: Wed Oct 05 13:53:38 2016 feedback: fix buttons overlapping text in long-text locales Since the ok/cancel buttons had "position: absolute", they would be positioned over the privacy text if the privacy text happened to be longer than it is in English. This change: 1) Makes the bottom buttons not use "position: absolute", which seems like it was only intended to apply to the "window control" buttons; 2) Makes the dialog taller, since the non-absolute buttons now can't overlap the text, which they previously did to save height. Note that this design is still fairly brittle; if locales have a much shorter privacy text, there'll be significant whitespace between the text and the bottom buttons, and if a locale has much longer text, the dialog will gain a scroll bar, which looks pretty ugly. BUG= 650978 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2388773002 Cr-Commit-Position: refs/heads/master@{#423148} [modify] https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf/chrome/browser/resources/feedback/css/feedback.css [modify] https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf/chrome/browser/resources/feedback/html/default.html [modify] https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf/chrome/browser/resources/feedback/js/event_handler.js
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, Sep 28 201692.6 KB
92.6 KB View Download