New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Color differences with hw decode

Reported by lexa.kny...@gmail.com, Sep 28 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. I have a source video file (MXF, DNxHD, 8-bit, 4:2:2).
2. I convert it to MP4/AVC with ffmpeg like this:

ffmpeg -i source.mxf 422.mp4
ffmpeg -i source.mxf -pix_fmt yuv420p 420.mp4

What is the expected behavior?

What went wrong?
There is a very noticeable color difference between two files, when playing them in Chrome (see attached image, left is 420, right is 422).

There is no color difference, when accelerated video decode is disabled via flags (see second attachment).

Btw, black levels are the same, so it should not be a color range issue.

Did this work before? N/A 

Is it a problem with Flash or HTML5? N/A

Does this work in other browsers? N/A 

Chrome version: 53.0.2785.116  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0
 
color_shift.png
1.1 MB View Download
no_color_shift.png
1.1 MB View Download
Owner: hubbe@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/070e970240f13d29be8930f9316f39ace711a116

commit 070e970240f13d29be8930f9316f39ace711a116
Author: hubbe <hubbe@chromium.org>
Date: Wed Nov 30 21:53:10 2016

This should a bunch of color decoding bugs on windows.
For DX9, this means using VideoProcessBlt instead of StretchRect()
(There is a fallback path for StretchRect, not sure if that is needed.)
This is controlled by "--enable-features=video-blit-color-accuracy" which defaults to off and will be enabled by an experiment.

BUG= 655417 ,  650977 ,  576419 ,  576411 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2503063002
Cr-Commit-Position: refs/heads/master@{#435431}

[modify] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/media/base/media_switches.cc
[modify] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/media/base/media_switches.h
[modify] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/media/gpu/dxva_picture_buffer_win.cc
[modify] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/media/gpu/dxva_video_decode_accelerator_win.cc
[modify] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/ui/gfx/BUILD.gn
[modify] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/ui/gfx/color_space.h
[add] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/ui/gfx/color_space_win.cc
[add] https://crrev.com/070e970240f13d29be8930f9316f39ace711a116/ui/gfx/color_space_win.h

Comment 3 by hubbe@chromium.org, Sep 8 2017

Status: Fixed (was: Assigned)
This should now (hopefully) be fixed. Please let me know if it is not.

Sign in to add a comment