New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650976 link

Starred by 1 user
Status: Fixed
Owner:
alito@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Back arrow navigation is not work for chrome://md-settings/resetProfileSettings

Reported by dmascare...@etouch.net, Sep 28 2016 
Chrome Version:55.0.2874.0 (Official Build) 3fe4bfc3b1cd9ccc14abf95597865d39ee7ae07b-refs/heads/master@{#421409}
OS:Windows (7,,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/resetProfileSettings
2. Click on 'Cross' button such that overlay get closed and then click on back navigation arrow.
3. Observe.

Actual: Back arrow navigation does not work for 'Md-settings'
Expected: Back arrow navigation should work for 'Md-settings'(i.e. Again 'Reset' overlay should get open similarly like Clear Browser Data overlay.)

This is non-regression issue,this is new feature introduce in 'M 55' (55.0.2874.0)

Good build:55.0.2873.0
Bad build:55.0.2874.0 

Note: Will soon update Mac and Linux info.

@alito: Please take a look.
Actual_reset.mp4
602 KB View Download

Comment 1 by msrchandra@chromium.org, Sep 28 2016

Cc: -alito@chromium.org
Labels: -Type-Bug -Pri-2 hasbisect-per-revision Pri-1 Type-Bug-Regression
Owner: alito@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2873.0 (Revision: 421052).
Bad build: 55.0.2874.0 (Revision: 421409).

You are probably looking for a change made after 421316 (known good), but no later than 421317 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds mightget missing due to failure.
 https://chromium.googlesource.com/chromium/src/+log/8ee4d2ad5fa99f247509e0967d9668f3bcf0f7b5..e8bfb7bfdf794c8f2995bd9b0da7db2f54618aca

@alito -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.

Comment 2 by alito@chromium.org, Sep 28 2016 

I have the following CL out for review to fix this issue:
https://codereview.chromium.org/2375223002/

Comment 3 by alito@chromium.org, Sep 29 2016 

What is left is for tests to be updated in the CL that was LGTM:ed since the fix involved some reshuffling of how the reset dialog works. I'm hoping to have a solution soon.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6716bef630b4eeca64d23a7396ff06db1e4083

commit 8c6716bef630b4eeca64d23a7396ff06db1e4083
Author: alito <alito@chromium.org>
Date: Sun Oct 09 18:41:27 2016

md-settings: Fix back navigation from /resetProfileSettings.

BUG= 650976 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2375223002
Cr-Commit-Position: refs/heads/master@{#424105}

[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/browser/resources/settings/reset_page/reset_page.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/browser/resources/settings/reset_page/reset_profile_banner.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_drawer_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_grouped_list_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_item_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_metrics_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_routing_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_supervised_user_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_synced_tabs_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/history_toolbar_test.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/md_history/test_util.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/polymer_browser_test_base.js
[modify] https://crrev.com/8c6716bef630b4eeca64d23a7396ff06db1e4083/chrome/test/data/webui/settings/reset_page_test.js

Comment 5 by alito@chromium.org, Oct 11 2016

Status: Fixed (was: Assigned)

Comment 6 by alito@chromium.org, Oct 11 2016 

This should now be fixed and should have made it into Canary.
►

Sign in to add a comment