New issue
Advanced search Search tips

Issue 650966 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

inspector/profiler/cpu-profiler-bottom-up-large-tree-search.html test fails on V8 layout test bots

Project Member Reported by alph@chromium.org, Sep 28 2016

Issue description

This happens under --ignition flag.

 

Comment 1 by alph@chromium.org, Sep 28 2016

Status: Assigned (was: Untriaged)
Seems to be happening because v8 cannot handle recursion of depth 1000 in ProfileTreeModel._calculateTotals
Components: Blink>JavaScript
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a46e69915c9b8e7d715243a470b8a7975e74109

commit 1a46e69915c9b8e7d715243a470b8a7975e74109
Author: alph <alph@chromium.org>
Date: Wed Sep 28 20:15:27 2016

DevTools: Remove recursion in ProfileTreeModel._calculateTotals

V8 fails with recursion depth of 1000 under --ignition.

BUG= 650966 

Review-Url: https://codereview.chromium.org/2379523002
Cr-Commit-Position: refs/heads/master@{#421622}

[modify] https://crrev.com/1a46e69915c9b8e7d715243a470b8a7975e74109/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-calculate-time.html
[modify] https://crrev.com/1a46e69915c9b8e7d715243a470b8a7975e74109/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js

Comment 5 by alph@chromium.org, Oct 10 2016

Status: Fixed (was: Assigned)

Sign in to add a comment