New issue
Advanced search Search tips

Issue 650965 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

service-worker-agents.html failing on chromium.webkit/WebKit Mac10.11 (dbg)

Project Member Reported by yukishiino@chromium.org, Sep 28 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)

Type: build-failure

Builders failed on: 
- WebKit Mac10.11 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29


http/tests/inspector/service-workers/service-worker-agents.html seems flaky,
and failed at build 4906, 4907, and 4909, but it's okay at 4908.
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/4906
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/4907
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/4909

Seeing the first failure at 4906, https://crrev.com/2354973003 seems suspicious.

 
 Issue 650955  could be related, but I'm not sure.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b38356129a7206f134a1cb57c8a567b9d8c938e9

commit b38356129a7206f134a1cb57c8a567b9d8c938e9
Author: dgozman <dgozman@chromium.org>
Date: Wed Sep 28 21:12:34 2016

[DevTools] Fix and rebaseline inspector/service-workers layout tests.

BUG= 650965 

Review-Url: https://codereview.chromium.org/2373913004
Cr-Commit-Position: refs/heads/master@{#421639}

[modify] https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-agents-expected.txt
[modify] https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-agents.html
[modify] https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager-expected.txt
[modify] https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager.html
[modify] https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-redundant-expected.txt
[modify] https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-redundant.html

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2

commit 28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Sep 29 00:32:33 2016

[inspector] fix crash in wrapping result for async Runtime.evaluate

BUG= chromium:651211 , chromium:650965 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2376143002
Cr-Commit-Position: refs/heads/master@{#39844}

[modify] https://crrev.com/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2/src/inspector/v8-runtime-agent-impl.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 30 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a07b43e938d28c8151d4254385cd4efff6c7975e

commit a07b43e938d28c8151d4254385cd4efff6c7975e
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Sep 30 05:43:10 2016

[DevTools] fix crash in wrapping result for async Runtime.evaluate

BUG= chromium:651211 ,  chromium:650965 
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/2381113003 .

Committed: https://crrev.com/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2
Cr-Original-Commit-Position: refs/heads/master@{#39844}
Cr-Commit-Position: refs/branch-heads/2840@{#596}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a07b43e938d28c8151d4254385cd4efff6c7975e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a07b43e938d28c8151d4254385cd4efff6c7975e

commit a07b43e938d28c8151d4254385cd4efff6c7975e
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Sep 30 05:43:10 2016

[DevTools] fix crash in wrapping result for async Runtime.evaluate

BUG= chromium:651211 ,  chromium:650965 
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/2381113003 .

Committed: https://crrev.com/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2
Cr-Original-Commit-Position: refs/heads/master@{#39844}
Cr-Commit-Position: refs/branch-heads/2840@{#596}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a07b43e938d28c8151d4254385cd4efff6c7975e/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Sign in to add a comment