webkit_tests failing on chromium.webkit/WebKit Linux Leak Type: build-failure Builders failed on: - WebKit Linux Leak: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak https://crrev.com/2227593002 is suspicious seeing https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/23307
This looked like it could be caused by crrev.com/5db8eb672a52385059d4d188e27d7a7f0a5dd29d Reverted in crrev.com/295acb8b68aa9b7084f5e35bad5aef9b427d9e03
Revert did not compile, reverted the revert.
New revert of that cl landed in crrev.com/e0efe32458df38eae4ed49d94f6772281dd46702 with related revert at crrev.com/9fad885c354ebf046e9506f85391cf4585991c05
Looks like the revert has stopped the failure. Will keep an eye on it.
I found these leaks are already tracked by another issue (Issue 506754). I'll reland the patch with updating LeakExpectation.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5de409e4f753ee6ac4aae3a19ec504db0b5907ea commit 5de409e4f753ee6ac4aae3a19ec504db0b5907ea Author: shimazu <shimazu@chromium.org> Date: Thu Sep 29 08:45:28 2016 Revert "Revert of ServiceWorker: Implement StartWorker by using mojo (patchset #1 id:1 of https://codereview.chromium.org/2378073002/ )" This reverts commit e0efe32458df38eae4ed49d94f6772281dd46702. Reason for revert: This patch actually does not cause Leak. It was already tracked by another issue: crbug.com/506754 TBR=horo@chromium.org,mek@chromium.org,dcheng@chromium.org,falken@chromium.org,avi@chromium.org BUG= 629701 ,506754, 650955 Review-Url: https://codereview.chromium.org/2374353002 Cr-Commit-Position: refs/heads/master@{#421780} [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/embedded_worker_instance.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/embedded_worker_instance.h [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/embedded_worker_registry.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/embedded_worker_registry.h [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/BUILD.gn [add] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/service_worker/embedded_worker.mojom [add] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/service_worker/embedded_worker.typemap [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/service_worker/embedded_worker_messages.h [add] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/service_worker/embedded_worker_start_params.cc [add] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/service_worker/embedded_worker_start_params.h [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/service_worker/service_worker_utils.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/service_worker/service_worker_utils.h [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/common/typemaps.gni [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/public/common/content_switches.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/public/common/content_switches.h [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/renderer/BUILD.gn [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/renderer/render_thread_impl.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/renderer/service_worker/embedded_worker_dispatcher.cc [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/renderer/service_worker/embedded_worker_dispatcher.h [add] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [add] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/content/renderer/service_worker/embedded_worker_instance_client_impl.h [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/third_party/WebKit/LayoutTests/LeakExpectations [modify] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/third_party/WebKit/LayoutTests/VirtualTestSuites [add] https://crrev.com/5de409e4f753ee6ac4aae3a19ec504db0b5907ea/third_party/WebKit/LayoutTests/virtual/mojo-service-worker/http/tests/serviceworker/README.txt
Comment 1 by jwd@chromium.org
, Sep 28 2016