New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650951 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 614588
issue 614589



Sign in to add a comment

‘Advanced’ section closed after clicking menu icon in md-settings

Reported by yfulgaon...@etouch.net, Sep 28 2016

Issue description

Chrome Version : 54.0.2840.41 (Official Build) aeb8895aa4becddb1526af10d1e67495713b6c1a-refs/branch-heads/2840@{#557} (64-bit)
OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings, scroll down the page and click on ‘Advanced’.
2. Now click on ‘Main menu’ icon seen at top left corner and press ‘Esc’ key.
3. Observe the ‘Advanced’ section.

Actual : Unnecessarily ‘Advanced’ section gets closed after clicking on ‘Main menu’ icon.
Expected : ‘Advanced’ section should not get closed after clicking on ‘Main menu’ icon.

This is a regression issue broken in ‘M-54’, below is the Manual Regression and will soon update bisect info.
Good build : 54.0.2832.0
Bad build : 54.0.2833.0
 
Actual_md_settings.mov
4.7 MB Download
Expected_md_settings.mov
4.4 MB Download
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good build : 54.0.2832.0 (412743)
Bad build : 54.0.2833.0 (413134)

You are probably looking for a change made after 420549 (known good), but no later than 420550 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/697e6fc2d3a21124b983953086d525576fdf15f5..cd81492dada5b5ad4c2f6914323145cd8a541eb2

Note: Adding RB Label as this is a recent Regression. Please remove if not required.
@ tommycli -- Could you please look into the issue.

Blocking: 614588 614589
Labels: -Pri-2 -M-54 -ReleaseBlock-Stable -Type-Bug-Regression Proj-MaterialDesign-WebUI OS-Chrome Pri-1 Type-Bug
Summary: ‘Advanced’ section closed after clicking menu icon in md-settings (was: Regression : Unnecessarily ‘Advanced’ section gets closed after clicking on ‘Main menu’ icon in md-settings.)

Comment 3 by dbeam@chromium.org, Oct 14 2016

Cc: michae...@chromium.org tommycli@chromium.org dschuyler@chromium.org dpa...@chromium.org
Owner: dbeam@chromium.org
actually, the repro steps are even simpler.

0. navigate to chrome://md-settings
1. click Advanced toggle
2. open side nav

what do you expect?
no change to the visibility of showing the advanced section

what happens instead?
the advanced section hides when you open the side nav.

Comment 4 by dbeam@chromium.org, Oct 14 2016

Status: Started (was: Assigned)

Comment 5 by dbeam@chromium.org, Oct 14 2016

so there's a few issues here:

1) all this tracking of whether advanced stuff is showing is complex

fix: https://codereview.chromium.org/2420833002/

2) when you use data binding for <paper-submenu opened="{{thing}}"> it doesn't work well (if you start with a truthy value the submenu takes a few clicks to right itself)

chrome-side: https://codereview.chromium.org/2412343004
upstream: https://github.com/PolymerElements/paper-menu/pull/107
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458

commit 5f9bf9e2c68a25b9bd02639c70d31c9c627cb458
Author: dbeam <dbeam@chromium.org>
Date: Mon Oct 17 22:35:02 2016

MD Settings: rework how advanced UI shows

Before, there were some events.  And booleans.  And maybe some binding.
It generally worked, but it was a little complex.  Now there's just
2-way bindings everywhere.  Changes from toggling the advanced buttons
in the main UI or in the nav flow to all other parties.  I also checked
that opening a page like /clearBrowserData works (all advanced toggles
and states work as expected).

Also, we probably had to call .open() or .close() explicitly because
<paper-submenu> has a bug when using only the opened="{{binding}}":
https://github.com/PolymerElements/paper-menu/issues/88

A fix for that bug is here:
https://github.com/PolymerElements/paper-menu/pull/107

I might also make a local change in Chrome's fork of Polymer if we must.

R=dpapad@chromium.org
BUG= 650951 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2420833002
Cr-Commit-Position: refs/heads/master@{#425795}

[modify] https://crrev.com/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/5f9bf9e2c68a25b9bd02639c70d31c9c627cb458/chrome/test/data/webui/settings/settings_menu_test.js

Comment 7 by dbeam@chromium.org, Oct 18 2016

Status: Fixed (was: Started)
https://codereview.chromium.org/2427743003 will address the double-tap issue without a Polymer change (but i'll still be tracking the Github PR)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb372ed35e94c5b140a09a3190cb4cfd058e6522

commit bb372ed35e94c5b140a09a3190cb4cfd058e6522
Author: dbeam <dbeam@chromium.org>
Date: Tue Oct 18 02:06:05 2016

MD Settings: fix double-tap to hide advanced bug

R=dpapad@chromium.org
BUG= 650951 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2427743003
Cr-Commit-Position: refs/heads/master@{#425856}

[modify] https://crrev.com/bb372ed35e94c5b140a09a3190cb4cfd058e6522/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/bb372ed35e94c5b140a09a3190cb4cfd058e6522/chrome/test/data/webui/settings/settings_ui_browsertest.js

Status: Verified (was: Fixed)
Verified on ChromeOS 8920.0.0, 56.0.2897.0

Sign in to add a comment