New issue
Advanced search Search tips

Issue 650944 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Rebaseline tool is broken (rebaseline trying to "git add" files which don't exist)

Project Member Reported by wangxianzhu@chromium.org, Sep 28 2016

Issue description

The rebaseline tool seems to have been broken for at least 5 days. Auto-r1ebaseline bot, webkit-patch rebaseline-expectations and webkit-patch rebaseline-cl are all affected.

Currently there are about 160 lines containing NeedsRebaseline in LayoutTests/TestExpectations. The oldest one was added 5 days ago.

When running rebaseline tool, an error like the following is raised:

Traceback (most recent call last):
  File "/usr/local/google/home/wangxianzhu/chrome/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/usr/local/google/home/wangxianzhu/chrome/src/third_party/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py", line 122, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command.py", line 110, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py", line 86, in execute
    self._rebaseline(options, test_prefix_list)
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 557, in _rebaseline
    self._tool.scm().add_list(change_set.files_to_add)
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 121, in add_list
    return self._run_git(["add"] + paths, return_exit_code=return_exit_code)
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 64, in _run_git
    return self._run(full_command_args, **full_kwargs)
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 61, in _run
    decode_output=decode_output)
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 392, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/usr/work/chrome/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 309, in default_error_handler
    raise error

webkitpy.common.system.executive.ScriptError: Failed to run "['git', 'add', ....
....]" exit_code: 128 cwd: /usr/work/chrome/src

output: fatal: pathspec '/usr/work/chrome/src/third_party/WebKit/LayoutTests/platform/linux-precise/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt' did not match any files

The rebaseline bot is failing because of the same error.
 
Summary: Rebaseline tool is broken (rebaseline trying to "git add" files which don't exist) (was: Rebaseline tool is broken)
This started happening after http://crrev.com/2380533003; started revert in http://crrev.com/2380533003.

Not entirely sure yet, but what I think is happening is: in the process of copy-existing-baselines, download-baselines, optimize-baselines, the list of files to `git add` is built up, but files which are moved/removed are not added to the `git rm` list and thus not being canceled out the way I thought they would.
Status: Fixed (was: Assigned)
Revert landed so this isn't failing anymore; next week I plan to re-land and follow up in  bug 639410 .

Sign in to add a comment