newer version of git breaks cleanup stage: `git update-ref -d patch_branch` dies with: error: refusing to update ref with bad name 'patch_branch' |
|||||||||||||||||||||||||||||||||||
Issue descriptionA variety of builders (the pre-cq-launcher, and many pre-cq bots) are seting repeated failures in the Cleanup stage. https://uberchromegw.corp.google.com/i/chromeos/builders/pre-cq-launcher/builds/7782/steps/CleanUp/logs/stdio @@@STEP_FAILURE@@@ 17:50:05: ERROR: <class 'chromite.lib.cros_build_lib.RunCommandError'>: return code: 1; command: git update-ref -d patch_branch error: refusing to update ref with bad name 'patch_branch' cwd=/b/cbuild/internal_master/src/private-overlays/overlay-variant-daisy-spring-private Traceback (most recent call last): File "/b/build/slave/pre-cq-launcher-master/build/chromite/lib/parallel.py", line 602, in TaskRunner task(*x, **task_kwargs) File "/b/build/slave/pre-cq-launcher-master/build/chromite/lib/parallel.py", line 800, in <lambda> fn = lambda idx, task_args: out_queue.put((idx, task(*task_args))) File "/b/build/slave/pre-cq-launcher-master/build/chromite/cbuildbot/commands.py", line 217, in RunCleanupCommands git.RunGit(cwd, ['update-ref', '-d', ref]) File "/b/build/slave/pre-cq-launcher-master/build/chromite/lib/git.py", line 829, in RunGit ['git'] + cmd, **kwargs) File "/b/build/slave/pre-cq-launcher-master/build/chromite/lib/retry_util.py", line 100, in GenericRetry ret = functor(*args, **kwargs) File "/b/build/slave/pre-cq-launcher-master/build/chromite/lib/cros_build_lib.py", line 624, in RunCommand raise RunCommandError(msg, cmd_result) RunCommandError: return code: 1; command: git update-ref -d patch_branch error: refusing to update ref with bad name 'patch_branch'
,
Sep 28 2016
Ningning realized that this is mostly happening on GCE builders. Then noticed that they have a different version of git (2.9 versus 2.8). "update-ref -d patch_branch" errors out in 2.9 if "patch_branch" doesn't exist. 2.8 didn't raise an error. So.... we are assuming there was a git update on the builders (via puppet), which broke us. Will be deploying a work around soon.
,
Sep 28 2016
,
Sep 28 2016
,
Sep 28 2016
Issue 651114 has been merged into this issue.
,
Sep 28 2016
,
Sep 28 2016
Re-opening to cover the merge. Elliot, did you update the version of git on the GCE instance,or did it happen through some other mechanism? It was appropriate to do the update, but I'm just wondering what the mechanism was.
,
Sep 28 2016
you'll prob need to cherry pick to active firmware & factory branches too :(
,
Sep 28 2016
All of this logic happens before the bootstrap, so that depends on which version of chromite the recipe checks out on those waterfalls. On the release waterfall, it starts with chromite from the given branch. In theory, not needed, but in practice it's probably saved us from some fire drills.
,
Sep 28 2016
,
Sep 28 2016
Please merge to M54/M53
,
Sep 28 2016
the physical builders are also upgraded to git 2.10, so this error is now happening in all builders(GCE and physical) for old branches. chrome-bot@build170-m2:(Linux 12.04):~$ git --version git version 2.10.0
,
Sep 28 2016
Ningning, do you want to do the merges (it's really your fix), or want me to do it?
,
Sep 28 2016
Dnj, which branch is Chromite checked out on the other waterfalls that use cbuildbot: branch chrome trybot Note to self: Check site specific builders to see if chromite pins need updating.
,
Sep 28 2016
sure, I can port the changes.
,
Sep 28 2016
AFAICT everything but branch uses ToT. Branch uses the branches defined here: https://chrome-internal.googlesource.com/chrome/tools/build/+/master/masters/master.chromeos.branch/branch_map.py
,
Sep 28 2016
Er, and release, which uses branches defined here: https://chrome-internal.googlesource.com/chrome/tools/build/+/master/scripts/common_internal/cros_chromite_internal_pins.json
,
Sep 28 2016
That said, TPMs often build stabilize branches, so I'd port to those for the release branch set as well.
,
Sep 28 2016
Is that branch map a full list of the branch builds we can still run? It's smaller than I was expecting.
,
Sep 28 2016
josafat@, just to confirm, the branches are: release-R54-8743.B, release-R53-8530.B and release-R52-8350.B?
,
Sep 28 2016
correct note that we are not releasing any M52 anymore so it may not be required to merge to that
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f16b0d3449307dc7b87e99e53e9868544f5854ba commit f16b0d3449307dc7b87e99e53e9868544f5854ba Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/390487 Reviewed-by: Shawn N <shawnn@chromium.org> Commit-Queue: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> [modify] https://crrev.com/f16b0d3449307dc7b87e99e53e9868544f5854ba/cbuildbot/commands.py
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c31c8e8748d4da1aa82f51d0e71ed9d967f188fb commit c31c8e8748d4da1aa82f51d0e71ed9d967f188fb Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/390484 Reviewed-by: Josafat Garcia <josafat@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/c31c8e8748d4da1aa82f51d0e71ed9d967f188fb/cbuildbot/commands.py
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9da44d6c4a815e795e5ede136cf2d02737f21562 commit 9da44d6c4a815e795e5ede136cf2d02737f21562 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/390485 Reviewed-by: Josafat Garcia <josafat@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/9da44d6c4a815e795e5ede136cf2d02737f21562/cbuildbot/commands.py
,
Sep 28 2016
,
Sep 28 2016
Finished porting for R53 and R54. If firmware* or factory* branch needs the fix, please port https://chromium-review.googlesource.com/#/c/390432/ to the branch to be run.
,
Sep 28 2016
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f6786e196abed28cc6f5c86e8eb8f620b5042fe6 commit f6786e196abed28cc6f5c86e8eb8f620b5042fe6 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/390972 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/f6786e196abed28cc6f5c86e8eb8f620b5042fe6/cbuildbot/commands.py
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/742e74dd3d42fc31d35b17a46b23a9c6be5f1827 commit 742e74dd3d42fc31d35b17a46b23a9c6be5f1827 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/390490 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/742e74dd3d42fc31d35b17a46b23a9c6be5f1827/cbuildbot/commands.py
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6fe953cb29cd89ae0da45ac066cdac2b9a205315 commit 6fe953cb29cd89ae0da45ac066cdac2b9a205315 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/390971 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/6fe953cb29cd89ae0da45ac066cdac2b9a205315/cbuildbot/commands.py
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/0841b3af196e1d771098a198b39ab264319100e8 commit 0841b3af196e1d771098a198b39ab264319100e8 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/391104 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/0841b3af196e1d771098a198b39ab264319100e8/cbuildbot/commands.py
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/0841b3af196e1d771098a198b39ab264319100e8 commit 0841b3af196e1d771098a198b39ab264319100e8 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/391104 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/0841b3af196e1d771098a198b39ab264319100e8/cbuildbot/commands.py
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/481f0dc393a8e5b76cd4638fb19848e03f844dac commit 481f0dc393a8e5b76cd4638fb19848e03f844dac Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/391092 Reviewed-by: Mohammed Habibulla <moch@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/481f0dc393a8e5b76cd4638fb19848e03f844dac/cbuildbot/commands.py
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/62dcdd8bf70964db7b6724afaecb1ea31447bddf commit 62dcdd8bf70964db7b6724afaecb1ea31447bddf Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/391106 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/62dcdd8bf70964db7b6724afaecb1ea31447bddf/cbuildbot/commands.py
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7618a8eec20cef6a6512f448fc55052d42114ed7 commit 7618a8eec20cef6a6512f448fc55052d42114ed7 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/392927 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/7618a8eec20cef6a6512f448fc55052d42114ed7/cbuildbot/commands.py
,
Oct 4 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/06aaad4a5c8250e4848c1b8a8a7bfd2ad7d2cd65 commit 06aaad4a5c8250e4848c1b8a8a7bfd2ad7d2cd65 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/393767 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/06aaad4a5c8250e4848c1b8a8a7bfd2ad7d2cd65/cbuildbot/commands.py
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/68d67b80e9cbd5776dbe97dd460d7b9ec04e4bb3 commit 68d67b80e9cbd5776dbe97dd460d7b9ec04e4bb3 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/393768 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/68d67b80e9cbd5776dbe97dd460d7b9ec04e4bb3/cbuildbot/commands.py
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/317a822bb48bf22cf619c247b29352b1ed617f75 commit 317a822bb48bf22cf619c247b29352b1ed617f75 Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/400806 Reviewed-by: Bernie Thompson <bhthompson@chromium.org> Commit-Queue: Bernie Thompson <bhthompson@chromium.org> Tested-by: Bernie Thompson <bhthompson@chromium.org> [modify] https://crrev.com/317a822bb48bf22cf619c247b29352b1ed617f75/cbuildbot/commands.py
,
Oct 25 2016
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c61189b50be70767f22ad74e1c5800d7b03a0bcd commit c61189b50be70767f22ad74e1c5800d7b03a0bcd Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/407777 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/c61189b50be70767f22ad74e1c5800d7b03a0bcd/cbuildbot/commands.py
,
Nov 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f2a1740dcffaeafdd2cb0070037c506f1fee957f commit f2a1740dcffaeafdd2cb0070037c506f1fee957f Author: Don Garrett <dgarrett@google.com> Date: Wed Sep 28 02:29:51 2016 commands: BuildRootGitCleanup ignore ref deletion error. Newer versions of git return errors of "git update-ref -d foo" is run and foo doesn't exist. Older versions returned without error. A git update on some servers broke us unexpectedly. BUG= chromium:650911 TEST=run_tests Change-Id: Iccd6bc9bc0b52821c29928617d20dba49fd14085 Reviewed-on: https://chromium-review.googlesource.com/390432 Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> (cherry picked from commit eb62387504ffea771d5cbef968292b458ff2cf8a) Reviewed-on: https://chromium-review.googlesource.com/409156 Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> Tested-by: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/f2a1740dcffaeafdd2cb0070037c506f1fee957f/cbuildbot/commands.py
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||||||
Comment 1 by dgarr...@chromium.org
, Sep 28 2016