TSAN data race for OSCryptConcurrencyTest.ConcurrentInitialization |
||
Issue descriptionOh, I thought you ran this through TSAN. https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tests/builds/2035 WARNING: ThreadSanitizer: data race (pid=30934) Read of size 1 at 0x00000a0f2640 by thread T1: #0 (anonymous namespace)::GetKeyStorage() components/os_crypt/os_crypt_linux.cc:68:22 (components_unittests+0x00000487179c) #1 OSCrypt::EncryptString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) components/os_crypt/os_crypt_linux.cc:155:21 (components_unittests+0x000004870fcf) #2 operator() components/os_crypt/os_crypt_unittest.cc:181:5 (components_unittests+0x000001180231) Previous write of size 1 at 0x00000a0f2640 by thread T2: #0 (anonymous namespace)::GetKeyStorage() components/os_crypt/os_crypt_linux.cc:69:41 (components_unittests+0x000004871823) #1 OSCrypt::EncryptString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) components/os_crypt/os_crypt_linux.cc:155:21 (components_unittests+0x000004870fcf) #2 operator() components/os_crypt/os_crypt_unittest.cc:181:5 (components_unittests+0x000001180231) WARNING: ThreadSanitizer: data race (pid=30934) Read of size 8 at 0x00000a0f2628 by thread T1: #0 get buildtools/third_party/libc++/trunk/include/memory:2714:76 (components_unittests+0x000004871970) #1 (anonymous namespace)::GetKeyStorage() components/os_crypt/os_crypt_linux.cc:72 (components_unittests+0x000004871970) #2 OSCrypt::EncryptString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) components/os_crypt/os_crypt_linux.cc:155:21 (components_unittests+0x000004870fcf) Previous write of size 8 at 0x00000a0f2628 by thread T2: #0 reset buildtools/third_party/libc++/trunk/include/memory:2733:24 (components_unittests+0x0000048718bc) #1 operator= buildtools/third_party/libc++/trunk/include/memory:2644 (components_unittests+0x0000048718bc) #2 (anonymous namespace)::GetKeyStorage() components/os_crypt/os_crypt_linux.cc:70 (components_unittests+0x0000048718bc) #3 OSCrypt::EncryptString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) components/os_crypt/os_crypt_linux.cc:155:21 (components_unittests+0x000004870fcf)
,
Oct 4 2016
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cad87469af6db5d25c08c956028f7f76dcafb53 commit 9cad87469af6db5d25c08c956028f7f76dcafb53 Author: Vaclav Brozek <vabr@chromium.org> Date: Tue Oct 04 14:39:37 2016 Fix race condition on OSCrypt linux This fixes the test that is broken on tsan. BUG= 650902 , 631171 Review-Url: https://codereview.chromium.org/2377973002 Cr-Commit-Position: refs/heads/master@{#421605} (cherry picked from commit 840961a10fc0c0e24299ced23a60908ffa09e9d1) Review URL: https://codereview.chromium.org/2390283002 . Cr-Commit-Position: refs/branch-heads/2840@{#636} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9cad87469af6db5d25c08c956028f7f76dcafb53/components/os_crypt/os_crypt_linux.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cad87469af6db5d25c08c956028f7f76dcafb53 commit 9cad87469af6db5d25c08c956028f7f76dcafb53 Author: Vaclav Brozek <vabr@chromium.org> Date: Tue Oct 04 14:39:37 2016 Fix race condition on OSCrypt linux This fixes the test that is broken on tsan. BUG= 650902 , 631171 Review-Url: https://codereview.chromium.org/2377973002 Cr-Commit-Position: refs/heads/master@{#421605} (cherry picked from commit 840961a10fc0c0e24299ced23a60908ffa09e9d1) Review URL: https://codereview.chromium.org/2390283002 . Cr-Commit-Position: refs/branch-heads/2840@{#636} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9cad87469af6db5d25c08c956028f7f76dcafb53/components/os_crypt/os_crypt_linux.cc |
||
►
Sign in to add a comment |
||
Comment 1 by cfroussios@chromium.org
, Sep 28 2016