I guess this is Internals>Network>Certificate, and not Internals>Network>SSL?

Sounds like Mac-Views issue; is there a better category for these?

(CC'ing based on  Issue 643123 )

MacViews is not used for any UI by default, so this isn't a MacViews bug, just a general mac UI bug. tapted@ is probably a good candidate.

I'll bump this to patti, since she's been deep in this logic. Specifically the test is:

  // Switch to another tab and verify that the sheet is hidden.
  AddBlankTabAndShow(browser());
  EXPECT_EQ(0.0, [sheetWindow alphaValue]);
  EXPECT_NSEQ(ui::kWindowSizeDeterminedLater, [sheetWindow frame]);


The first EXPECT succeeds, the second fails. But I think that's fine - this is actually a bug that patti fixed in r400627 - moving an invisible window to ui::kWindowSizeDeterminedLater actually makes the bottom left corner pixel of the screen unclickable. r400627 fixed that.

The weirder things to investigate are
 - why isn't this failing on other OSX versions already
 - why is [sheetWindow frame] getting a negative origin
 - is tab-switching with the SSL certificate showing actually working OK in Sierra (I did some spot checks earlier and it seemed fine, but patti knows all the corner cases better than I do).

I tested beta build 54.0.2840.50 on 10.12 Sierra and the SSL Client Certificate selection box is displayed and allows me to log into a website with a certificate.

Ping, this is now blocking our 10.12 rollout.

Thanks for the heads up on this Erik. The expectation that this test was failing on has been replaced (in r400627, as Trent mentioned). The test seems to be passing fine as well on Sierra, but I did a couple manual checks and it seems like the invisible overlay window which is used to block interaction with the tab while the certificate viewer is open isn't working again when switching between two tabs with certificate viewers open. (The first certificate viewer becomes unclickable, but is still key window.) I'm not sure why this is the case, will look into that now.

While poking around some unconverted dialogs, I realised that this is actually the SSLCertificate *Selector* not the SSLCertificate *Viewer*.

So this test might actually be failing (indirectly?) because of  Issue 653093  ~"AppKit does dodgy stuff with SFChooseIdentityPanel on macOS 10.12 Sierra"

There is also Issue 671889 "SecTrustSetKeychains does not work on Mac OS 10.12", and  Issue 666733  "[Mac] Client certificate modal is not keyboard-navigable".

One option available is to put the client certificate selection dialog behind --secondary-ui-md on Mac. But that might be too big a change. We currently use a (mostly) OS-provided dialog (similar to the SSL certificate viewer). Also the toolkit-views dialog has a views::TableView which lacks a good deal of polish (and is the reason we are deferring conversion of the task manager).

You're right Trent, I was also looking at the certificate viewer instead of the selector. Not sure how to answer the questions you had in #c4, but the test can be fixed by applying the same code used for the certificate viewer to the selector in this CL: https://codereview.chromium.org/2559763003/. This introduces the unclickable-ness to the certificate selector now though too (mentioned in #c7), so there's a fix for the certificate viewer (Cocoa + MacViews) and the certificate selector in a follow-up here: https://codereview.chromium.org/2562653002/.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88fc23eb6caa37caec392c54ceeab245e5adaac3

commit 88fc23eb6caa37caec392c54ceeab245e5adaac3
Author: patricialor <patricialor@chromium.org>
Date: Tue Dec 13 05:40:20 2016

Mac: Fix SSLClientCertificateSelectorCocoaTest.HideShow (fails on macOS Sierra).

SSLClientCertificateSelectorCocoaTest.HideShow is failing on macOS Sierra,
blocking 10.12 rollout for Chrome. Fix this using the same refactor as seen in
r400627, which ignores mouse events instead of resizing the certificate selector
window when it's hidden.

BUG= 650898 

Review-Url: https://codereview.chromium.org/2559763003
Cr-Commit-Position: refs/heads/master@{#438065}

[modify] https://crrev.com/88fc23eb6caa37caec392c54ceeab245e5adaac3/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
[modify] https://crrev.com/88fc23eb6caa37caec392c54ceeab245e5adaac3/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
[modify] https://crrev.com/88fc23eb6caa37caec392c54ceeab245e5adaac3/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

As mentioned previously, the above change introduces  Issue 671150  to the certificate selector also (along with the certificate viewer for MacViews and Cocoa for which it already exists). Since 671150 is a rare repro case and it's easy to recover from it, putting that on the backburner (see bug for more details). Closing this bug as fixed now :)