New issue
Advanced search Search tips

Issue 650885 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 653371



Sign in to add a comment

Investigate optimizing out layer updates for layers that will not be drawn.

Project Member Reported by khushals...@chromium.org, Sep 27 2016

Issue description

The compositor uses draw_property_utils::FindLayersThatNeedsUpdates to optimize out updating of layers that will not be drawn in a frame update.

Currently we update all the layers in LayerTreeHostRemote::BeginMainFrame. Investigate using the same optimization to restrict sending of layer content for these layers.

 
cc unit test LayerTreeHostTestSwitchMaskLayer in layer_tree_host_unittest.cc will fail for remote LTH, since LTH in process won't update all the layers. 

Blocking: 653371
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0679741aca67ad446f6262645d8d65e8d0ab802

commit a0679741aca67ad446f6262645d8d65e8d0ab802
Author: khushalsagar <khushalsagar@chromium.org>
Date: Wed Nov 02 00:45:59 2016

cc/blimp: Eliminate Layer updates for common cases.

In the threaded compositor, we optimize out updates for layers that
will not be drawn after building/updating PropertyTrees. Use some of
that logic in the remote LayerTreeHost.

BUG= 650885 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2467043002
Cr-Commit-Position: refs/heads/master@{#429165}

[modify] https://crrev.com/a0679741aca67ad446f6262645d8d65e8d0ab802/cc/blimp/compositor_state_deserializer_unittest.cc
[modify] https://crrev.com/a0679741aca67ad446f6262645d8d65e8d0ab802/cc/blimp/layer_tree_host_remote.cc
[modify] https://crrev.com/a0679741aca67ad446f6262645d8d65e8d0ab802/cc/blimp/layer_tree_host_remote_unittest.cc
[modify] https://crrev.com/a0679741aca67ad446f6262645d8d65e8d0ab802/cc/layers/layer.cc

Status: WontFix (was: Assigned)

Sign in to add a comment