New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 650835 link

Starred by 1 user
Status: Assigned
Owner:
michae...@chromium.org
Cc:
abodenha@chromium.org
█ kalq@chromium.org
r...@chromium.org
tbarzic@chromium.org
michae...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 505926
issue 627975



Sign in to add a comment

Move the bluetooth_low_energy API out of //chrome/browser/extensions/api

Project Member Reported by st...@chromium.org, Sep 27 2016 
The bluetoothLowEnergy API has no dependencies on //chrome and is needed by AppShell users. We need to move it out of //chrome into //extensions to allow AppShell to use it.

The major blocker in moving this API is the tests, which depend on code in //chrome. As part of this work, we'll refactor the tests to move them out of //chrome also.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746

commit c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746
Author: steel <steel@chromium.org>
Date: Thu Sep 29 00:56:27 2016

Move chrome.bluetoothLowEnergy out of //chrome.

This CL moves the Bluetooth Low Energy API out of //chrome and into
//extensions. This will allow us to use this API from AppShell.

This CL also adds the Kiosk Delegate. On Chrome, this delegate will mostly
have stubbed functionality but the delegate does need to exist on all
platforms. This is because AppShell is not restricted only to Chrome OS so
the API will need to be compiled for multiple platforms, whether it is
compiling under a Chrome build or an AppShell build.

Moving the tests will be fairly complicated due to various dependencies
on InProcBrowserTest and ExtensionApiTest. Hence I'll send out a separate
follow on CL to move the tests.

R=rdevlin.cronin@chromium.org, xiyuan@chromium.org
BUG=650835

Review-Url: https://codereview.chromium.org/2370373002
Cr-Commit-Position: refs/heads/master@{#421700}

[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/chrome_extensions_browser_client.h
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/chrome_kiosk_delegate.cc
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/chrome_kiosk_delegate.h
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/browser/extensions/chrome_kiosk_delegate_chromeos.cc
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/BUILD.gn
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/BUILD.gn
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/BUILD.gn
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_api_advertisement.cc
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_api_advertisement.h
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.cc
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.h
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_connection.cc
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_connection.h
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.cc
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_notify_session.h
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/utils.cc
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/api/bluetooth_low_energy/utils.h
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/extensions_browser_client.h
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/kiosk/BUILD.gn
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/kiosk/kiosk_delegate.cc
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/kiosk/kiosk_delegate.h
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/test_extensions_browser_client.cc
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/browser/test_extensions_browser_client.h
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/common/api/BUILD.gn
[rename] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/common/api/bluetooth_low_energy.idl
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/shell/BUILD.gn
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/shell/browser/delegates/shell_kiosk_delegate.cc
[add] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/shell/browser/delegates/shell_kiosk_delegate.h
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/shell/browser/shell_extensions_api_client.cc
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/shell/browser/shell_extensions_browser_client.cc
[modify] https://crrev.com/c8e6edea4ad306b0b0bb26ebcb67bb8a4cb91746/extensions/shell/browser/shell_extensions_browser_client.h

Comment 2 by st...@chromium.org, Dec 12 2016

Owner: michae...@chromium.org
Status: Assigned (was: Started)
Only tests remain, which should be done as part of the work that michaelpg@ will be doing.

Comment 3 by michae...@chromium.org, Feb 26 2017

Components: Platform>Apps>Shell

Comment 4 by r...@chromium.org, Mar 3 2017

Cc: r...@chromium.org
►

Sign in to add a comment