New issue
Advanced search Search tips

Issue 650832 link

Starred by 1 user
Status: Fixed
Owner:
xingliu@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 597756



Sign in to add a comment

Add snackbars for error/info messages for blimp

Project Member Reported by nyquist@chromium.org, Sep 27 2016 
Currently, there is almost no UI for users to be able to understand what is going on. For example, a crash in the engine has as a symptom that things just stop working instead of giving the user an error message.

We should make use of the Chrome snackbars to inform users of error events and other info messages.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b

commit de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b
Author: xingliu <xingliu@chromium.org>
Date: Tue Oct 11 16:37:59 2016

Propagate error messages to UI for Blimp.

This CL added a Java side UI class to show error messages in Toast or
Snackbar.

Also modified the BlimpClientContext interface for proper error
handling.

Future work: Pulling strings from grd files, this involves some amount
of work, so setup string resources will be done in other CLs.

BUG= 650832 

Review-Url: https://codereview.chromium.org/2391263005
Cr-Commit-Position: refs/heads/master@{#424453}

[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/app/linux/blimp_client_context_delegate_linux.cc
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/app/linux/blimp_client_context_delegate_linux.h
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/core/context/blimp_client_context_impl.cc
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/core/context/blimp_client_context_impl.h
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/core/session/identity_source.cc
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/core/session/identity_source_unittest.cc
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/public/blimp_client_context_delegate.h
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/blimp/client/test/test_blimp_client_context_delegate.h
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/android/java/src/org/chromium/chrome/browser/blimp/ChromeBlimpClientContextDelegate.java
[add] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/android/java/src/org/chromium/chrome/browser/blimp/ui/BlimpMessageBuilder.java
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/android/java_sources.gni
[add] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpMessageBuilderTest.java
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.h
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/browser/android/blimp/chrome_blimp_client_context_delegate_android.cc
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/chrome/browser/android/blimp/chrome_blimp_client_context_delegate_android.h
[modify] https://crrev.com/de3b7c37ab34ad7e6d46f8d205e4e2a449c8fe9b/tools/metrics/histograms/histograms.xml

Comment 2 by xingliu@chromium.org, Oct 18 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment