New issue
Advanced search Search tips

Issue 650801 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 622481
issue 650854



Sign in to add a comment

Prepare chrome/common/service_process_util_mac.mm for 10.8 deployment target.

Project Member Reported by erikc...@chromium.org, Sep 27 2016

Issue description

chrome/common/service_process_util_mac.mm uses FSRef just for basic filesystem navigation, it appears. This is easily replaceable with NSURL.

I believe thakis@ may already have an untested patch for this.
 
[25551/38611] OBJCXX obj/chrome/common/common/service_process_util_mac.o
../../chrome/common/service_process_util_mac.mm:65:10: warning: 'FSGetCatalogInfo' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations]
  return FSGetCatalogInfo(&child, 0, NULL, NULL, NULL, parent) == noErr;
         ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Files.h:2620:15: note: 'FSGetCatalogInfo' has been explicitly marked deprecated here
extern OSErr  FSGetCatalogInfo(const FSRef *ref, FSCatalogInfoBitmap whichInfo, FSCatalogInfo *catalogInfo, HFSUniStr255 *outName, FSSpecPtr fsSpec, FSRef *parentRef) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_8, __IPHONE_NA, __IPHONE_NA);
              ^
../../chrome/common/service_process_util_mac.mm:349:13: warning: 'CFURLCreateFromFSRef' is deprecated: first deprecated in macOS 10.9 [-Wdeprecated-declarations]
            CFURLCreateFromFSRef(kCFAllocatorDefault, &bundle_fsref));
            ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:472:10: note: 'CFURLCreateFromFSRef' has been explicitly marked deprecated here
CFURLRef CFURLCreateFromFSRef(CFAllocatorRef allocator, const struct FSRef *fsRef) CF_DEPRECATED(10_0, 10_9, 2_0, 7_0);
         ^
../../chrome/common/service_process_util_mac.mm:363:17: warning: 'FSDetermineIfRefIsEnclosedByFolder' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations]
    OSErr err = FSDetermineIfRefIsEnclosedByFolder(kOnAppropriateDisk,
                ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Folders.h:967:1: note: 'FSDetermineIfRefIsEnclosedByFolder' has been explicitly marked deprecated here
FSDetermineIfRefIsEnclosedByFolder(
^
../../chrome/common/service_process_util_mac.mm:373:13: warning: 'FSCompareFSRefs' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations]
        if (FSCompareFSRefs(&path_ref, &executable_fsref_) == noErr) {
            ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Files.h:1850:15: note: 'FSCompareFSRefs' has been explicitly marked deprecated here
extern OSErr  FSCompareFSRefs(const FSRef *ref1, const FSRef *ref2)                     __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_8, __IPHONE_NA, __IPHONE_NA);
              ^
4 warnings generated.
Blocking: 650854
Owner: erikc...@chromium.org
Status: Fixed (was: Untriaged)
Fixed: https://codereview.chromium.org/2398243002/
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a91e106df6f335cfdf7602c8bda6804c4eff74a6

commit a91e106df6f335cfdf7602c8bda6804c4eff74a6
Author: erikchen <erikchen@chromium.org>
Date: Wed Oct 12 21:30:58 2016

Expand warning suppression in service_process_util_mac.mm.

There are two deprecated methods being called side by side. The warning
suppression incorrectly only targetd one of the two methods.

BUG= 650801 

Review-Url: https://codereview.chromium.org/2416653002
Cr-Commit-Position: refs/heads/master@{#424865}

[modify] https://crrev.com/a91e106df6f335cfdf7602c8bda6804c4eff74a6/chrome/common/service_process_util_mac.mm

Sign in to add a comment