Prepare chrome/browser/download/download_status_updater_mac.mm for 10.8 deployment target. |
|||
Issue descriptionFNNotifyByPath is deprecated since 10.8. It should be replaceable by -[NSWorkspace noteFileSystemChanged:]. 250 FNNotifyByPath( 251 reinterpret_cast<const UInt8*>([parent_path fileSystemRepresentation]), 252 kFNDirectoryModifiedMessage, 253 kNilOptions);
,
Oct 4 2016
https://codereview.chromium.org/2391573004
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea963b6148fe1cb2b425a0e527883a830b3e16e7 commit ea963b6148fe1cb2b425a0e527883a830b3e16e7 Author: rsesek <rsesek@chromium.org> Date: Tue Oct 04 22:45:42 2016 [Mac] Remove usage of deprecated FNNotifyByPath(). This moves to using -[NSWorkspace noteFileSystemChanged:], which internally strips the last path component and calls the deprecated function. BUG= 650794 R=avi@chromium.org Review-Url: https://codereview.chromium.org/2391573004 Cr-Commit-Position: refs/heads/master@{#422977} [modify] https://crrev.com/ea963b6148fe1cb2b425a0e527883a830b3e16e7/chrome/browser/download/download_status_updater_mac.mm
,
Oct 5 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by erikc...@chromium.org
, Sep 27 2016[23250/38611] OBJCXX obj/chrome/browser/browser/download_status_updater_mac.o ../../chrome/browser/download/download_status_updater_mac.mm:246:5: warning: 'FNNotifyByPath' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations] FNNotifyByPath( ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Files.h:4267:18: note: 'FNNotifyByPath' has been explicitly marked deprecated here extern OSStatus FNNotifyByPath(const UInt8 *path, FNMessage message, OptionBits flags) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_8, __IPHONE_NA, __IPHONE_NA); ^ 1 warning generated.