New issue
Advanced search Search tips

Issue 650792 link

Starred by 1 user
Status: Fixed
Owner:
joedow@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[It2Me][Host] Fix task_runner assignment in confirmation dialog proxy

Project Member Reported by joedow@chromium.org, Sep 27 2016 
Per comments in CR: https://codereview.chromium.org/2372833002/, we should remove the confirmation_dialog member from the It2MeHost class as well as the task_runner() member.  This means moving the dialog_proxy member initialization into the c'tor but the proxy class makes assumptions about where it will run based on when it is created so that will also need to be fixed.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61431fea97b63bf714d7b411e68b9321d09bbb38

commit 61431fea97b63bf714d7b411e68b9321d09bbb38
Author: joedow <joedow@chromium.org>
Date: Thu Sep 29 19:39:05 2016

It2Me Host cleanup - Remove task_runner_

This member seems to have been used when we ran code using a plugin_task_runner
that was passed in to us, however that is no longer the case and we can now
use the host_context_ for all of our task running needs.  I also removed some
invalid DCHECKs that were required in the past, but were incorrectly updated
in previous CLs and are no longer useful.

BUG= 650792 

Review-Url: https://codereview.chromium.org/2380463005
Cr-Commit-Position: refs/heads/master@{#421905}

[modify] https://crrev.com/61431fea97b63bf714d7b411e68b9321d09bbb38/remoting/host/it2me/it2me_host.cc
[modify] https://crrev.com/61431fea97b63bf714d7b411e68b9321d09bbb38/remoting/host/it2me/it2me_host.h
[modify] https://crrev.com/61431fea97b63bf714d7b411e68b9321d09bbb38/remoting/host/it2me/it2me_native_messaging_host_unittest.cc

Comment 2 by joedow@chromium.org, Sep 29 2016

Status: Started (was: Assigned)

Comment 3 by joedow@chromium.org, Sep 29 2016

Status: Verified (was: Started)
Summary: [It2Me][Host] Fix task_runner assignment in confirmation dialog proxy (was: [It2Me][Host] Fix task_runner assignment and checking in the host and confirmation dialog proxy)

Comment 4 by joedow@chromium.org, Sep 29 2016 

After discussion with Sergey, the changes needed to remove the confirmation_dialog member are actually pretty decent in scope (due o thread affinity in the proxy) so I am going to call this good with the task_runner update.

Comment 5 by joedow@chromium.org, Sep 29 2016

Status: Fixed (was: Verified)
►

Sign in to add a comment