Bad movementX/Y values when exiting and reentring window |
|||||
Issue descriptionPointer Lock specification https://github.com/w3c/pointerlock requires that mouse movement events include movementX/Y values are zeroed when exiting and then reentering a window. http://w3c-test.org/pointerlock/movementX_Y_no-jumps-manual.html tests for this. Chrome on Mac implements this correctly, but Windows, Linux, Chrome OS have large values emitted.
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/116116ab28e3d6f1c9320f921e77e084426588ca commit 116116ab28e3d6f1c9320f921e77e084426588ca Author: ananta <ananta@chromium.org> Date: Fri Oct 07 21:59:47 2016 Ensure that we don't report huge mouse movement deltas for mouse enter and leave events. The movement deltas are supposed to be fixed by the RWHVA::ModifyEventMovementAndCoords function. However this function does not do the right thing because it checks the WebMouseEvent structure for a mouse enter or leave event. The WebMouseEvent structure never sees a mouse enter or leave event as they are converted to a mouse move event with the cursor position as the location. Fixes as below:- 1. Pass the ui::MouseEvent structure to the RWHVA::ModifyEventMovementAndCoords function and use this to check if the mouse event is a mouse enter or leave. BUG= 650787 TBR=jam Review-Url: https://codereview.chromium.org/2386103004 Cr-Commit-Position: refs/heads/master@{#423977} [modify] https://crrev.com/116116ab28e3d6f1c9320f921e77e084426588ca/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/116116ab28e3d6f1c9320f921e77e084426588ca/content/browser/renderer_host/render_widget_host_view_aura.h
,
May 5 2017
Deprecate IO>PointerLock
,
Sep 14 2017
ananta@ Just want to check: Are you planning to land more patches or the issue has been fixed by #2? Thanks!
,
Jan 9 2018
,
Aug 21
,
Aug 23
This looks like it works correctly on Windows and Linux 68.0.3440.106. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by scheib@chromium.org
, Sep 27 2016