New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650787 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 359740



Sign in to add a comment

Bad movementX/Y values when exiting and reentring window

Project Member Reported by scheib@chromium.org, Sep 27 2016

Issue description

Pointer Lock specification https://github.com/w3c/pointerlock requires that mouse movement events include movementX/Y values are zeroed when exiting and then reentering a window.

http://w3c-test.org/pointerlock/movementX_Y_no-jumps-manual.html tests for this.

Chrome on Mac implements this correctly, but
Windows, Linux, Chrome OS have large values emitted.
 

Comment 1 by scheib@chromium.org, Sep 27 2016

Blocking: 359740
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/116116ab28e3d6f1c9320f921e77e084426588ca

commit 116116ab28e3d6f1c9320f921e77e084426588ca
Author: ananta <ananta@chromium.org>
Date: Fri Oct 07 21:59:47 2016

Ensure that we don't report huge mouse movement deltas for mouse enter and leave events.

The movement deltas are supposed to be fixed by the RWHVA::ModifyEventMovementAndCoords function.
However this function does not do the right thing because it checks the WebMouseEvent structure for a
mouse enter or leave event. The WebMouseEvent structure never sees a mouse enter or leave event as they
are converted to a mouse move event with the cursor position as the location.

Fixes as below:-
1. Pass the ui::MouseEvent structure to the RWHVA::ModifyEventMovementAndCoords function and use this
   to check if the mouse event is a mouse enter or leave.

BUG= 650787 
TBR=jam

Review-Url: https://codereview.chromium.org/2386103004
Cr-Commit-Position: refs/heads/master@{#423977}

[modify] https://crrev.com/116116ab28e3d6f1c9320f921e77e084426588ca/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/116116ab28e3d6f1c9320f921e77e084426588ca/content/browser/renderer_host/render_widget_host_view_aura.h

Components: -IO>PointerLock Blink>Input>PointerLock
Deprecate IO>PointerLock

Comment 4 by chongz@chromium.org, Sep 14 2017

Cc: chongz@chromium.org
Owner: ananta@chromium.org
Status: Assigned (was: Available)
ananta@ Just want to check: Are you planning to land more patches or the issue has been fixed by #2?

Thanks!
Cc: -scheib@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Unassigning all bugs for ananta@chromium.org
Cc: bokan@chromium.org
Status: WontFix (was: Untriaged)
This looks like it works correctly on Windows and Linux 68.0.3440.106. 

Sign in to add a comment