Issue 650779 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	agrieve@chromium.org
Closed:	Sep 2016
Components:	Build
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	3
Type:	Bug

Java targets should be able to use org.chromium.base.BuildConfig without directly including its src_jar target

Project Member Reported by agrieve@chromium.org, Sep 27 2016

Issue description

Right now any target that wants to use base_java's BuildConfig or NativeLibraries classes will not compile unless they explicitly compile in the corresponding .srcjar and add the jar_excluded_patterns for the class.

This should be made to "just work" if a target depends on base_java.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c579600f6fa4a7b90baf904118aba0f47349fa

commit a6c579600f6fa4a7b90baf904118aba0f47349fa
Author: agrieve <agrieve@chromium.org>
Date: Wed Sep 28 14:18:19 2016

Allow targets to use BuildConfig by simply depending on base_java

BUG= 650779 
TBR=nyquist

Review-Url: https://codereview.chromium.org/2373853002
Cr-Commit-Position: refs/heads/master@{#421516}

[modify] https://crrev.com/a6c579600f6fa4a7b90baf904118aba0f47349fa/android_webview/glue/BUILD.gn
[modify] https://crrev.com/a6c579600f6fa4a7b90baf904118aba0f47349fa/build/config/android/internal_rules.gni
[modify] https://crrev.com/a6c579600f6fa4a7b90baf904118aba0f47349fa/chrome/android/BUILD.gn
[modify] https://crrev.com/a6c579600f6fa4a7b90baf904118aba0f47349fa/testing/android/native_test/BUILD.gn

Comment 2 by agrieve@chromium.org, Sep 29 2016

Status: Fixed (was: Started)

►

Issue 650779 link

Issue metadata

Java targets should be able to use org.chromium.base.BuildConfig without directly including its src_jar target

Issue description

Comment 1 by bugdroid1@chromium.org, Sep 28 2016

Comment 1 Deleted

Comment 2 by agrieve@chromium.org, Sep 29 2016

Comment 2 Deleted

Sign in to add a comment