New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 650776 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 617296
issue 621791



Sign in to add a comment

TrayDetailsViewTest.TransitionToDefaultViewTest detailed view activation

Project Member Reported by warx@chromium.org, Sep 27 2016

Issue description

on tot

https://cs.chromium.org/chromium/src/ash/common/system/tray/tray_details_view_unittest.cc?q=traydetailsviewtest&sq=package:chromium&l=170

before line 170, 
if this line is added 
EXPECT_TRUE(test_item_2->detailed_view()->GetWidget()->IsActive());
it will fail.

This test used to pass on a cl that I am working on.

I am not sure what goes wrong. @tdanderson, can you have a check or an idea what may happen? I saw recently you had a CL on this file. Thanks!

 

Comment 1 by warx@chromium.org, Sep 27 2016

Blocking: 621791
Owner: warx@chromium.org
Status: Assigned (was: Untriaged)
Let me take a look.

Comment 2 by warx@chromium.org, Sep 27 2016

a tray->ActivateBubble() call before test_item_2->detailed_view()->FocusTitleRow() will fix this. I will merge the fix into the CL in 621791.
Blocking: 617296
Labels: M-56
Owner: tdander...@chromium.org
Status: Started (was: Assigned)
This is actually a functional regression in material design. I'm working on a CL to fix this now.
Labels: Proj-MaterialDesign-CrOS
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/999329346d570fcd2732b703691fc829021b7c54

commit 999329346d570fcd2732b703691fc829021b7c54
Author: tdanderson <tdanderson@chromium.org>
Date: Thu Oct 20 17:53:11 2016

[Ash MD] Restore focus on detailed row when exiting detailed view

For Ash material design (--ash-md=experimental), restore
focus to the previously-focused system menu row
when transitioning away from a detailed view using
the keyboard (i.e., when the back button has focus and
the return key is pressed).

BUG= 650776 
TEST=TrayDetailsViewTest.TransitionToDefaultViewTest

Review-Url: https://chromiumcodereview.appspot.com/2434553003
Cr-Commit-Position: refs/heads/master@{#426524}

[modify] https://crrev.com/999329346d570fcd2732b703691fc829021b7c54/ash/common/system/tray/tray_details_view.cc
[modify] https://crrev.com/999329346d570fcd2732b703691fc829021b7c54/ash/common/system/tray/tray_details_view_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c16e0e849526c1c627e08a05351ab38a9cfbcf1

commit 5c16e0e849526c1c627e08a05351ab38a9cfbcf1
Author: warx <warx@chromium.org>
Date: Fri Oct 21 21:55:46 2016

Do not give instant focus if a view's toplevelwidget is not active

If the top level widget isn't active during setting focus view, we store the focused view and then attempt to activate the widget. If activation succeeds view will be focused. If activation fails |view| will be focused the next time the widget is made active.

Based on this rule, a set of unittests related are modified.

This is a following up CL for 2113163002 as there are already too many patches there.

BUG= 621791 
BUG= 650776 
BUG= 152938 
TEST=add an interactive_ui_test, NativeWidgetAuraTest.NonActiveWindowRequestImeFocus

Review-Url: https://chromiumcodereview.appspot.com/2371113003
Cr-Commit-Position: refs/heads/master@{#426905}

[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ash/common/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_ash_unittest.cc
[delete] https://crrev.com/b07f20559996aa8154a3a67e742676a9799e37c4/chrome/browser/ui/views/toolbar/toolbar_view_browsertest.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/chrome/test/BUILD.gn
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/controls/combobox/combobox_unittest.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/focus/focus_manager.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/view_targeter_unittest.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[add] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/5c16e0e849526c1c627e08a05351ab38a9cfbcf1/ui/views/widget/root_view_unittest.cc

Status: Verified (was: Fixed)

Sign in to add a comment